From 6a91645a842eebc863049ada92902f590dee405e Mon Sep 17 00:00:00 2001 From: "palfia@homejinni.com" Date: Thu, 20 Jun 2013 15:29:22 +0000 Subject: [PATCH] MIPS: Fix stack frame reconstruction for generators with formal arguments. Port r15230 (e2bbe01) Original commit message: The formal parameter count was always being treated as an untagged integer, but it is actually a Smi on ia32 and arm. BUG=v8:2355 TEST=mjsunit/harmony/generators-iteration Review URL: https://codereview.chromium.org/17261028 Patch from Balazs Kilvady . git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15250 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/mips/full-codegen-mips.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc index df83019..06226ca 100644 --- a/src/mips/full-codegen-mips.cc +++ b/src/mips/full-codegen-mips.cc @@ -2142,7 +2142,7 @@ void FullCodeGenerator::EmitGeneratorResume(Expression *generator, __ LoadRoot(a2, Heap::kTheHoleValueRootIndex); Label push_argument_holes, push_frame; __ bind(&push_argument_holes); - __ Subu(a3, a3, Operand(1)); + __ Subu(a3, a3, Operand(Smi::FromInt(1))); __ Branch(&push_frame, lt, a3, Operand(zero_reg)); __ push(a2); __ jmp(&push_argument_holes); -- 2.7.4