From 6a81e694ab806d257e43cbc2e32c06099d70cbd8 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Wed, 17 May 2023 07:07:52 +0000 Subject: [PATCH] [clang][dataflow] Remove unused parameter from `diagnoseUnwrapCall()`. Reviewed By: sammccall Differential Revision: https://reviews.llvm.org/D150756 --- .../Models/UncheckedOptionalAccessModel.cpp | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp b/clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp index 680c4d1..24a3682 100644 --- a/clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp +++ b/clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp @@ -864,8 +864,7 @@ auto buildTransferMatchSwitch() { .Build(); } -std::vector diagnoseUnwrapCall(const Expr *UnwrapExpr, - const Expr *ObjectExpr, +std::vector diagnoseUnwrapCall(const Expr *ObjectExpr, const Environment &Env) { if (auto *OptionalVal = getValueBehindPossiblePointer(*ObjectExpr, Env)) { auto *Prop = OptionalVal->getProperty("has_value"); @@ -893,16 +892,16 @@ auto buildDiagnoseMatchSwitch( valueCall(IgnorableOptional), [](const CXXMemberCallExpr *E, const MatchFinder::MatchResult &, const Environment &Env) { - return diagnoseUnwrapCall(E, E->getImplicitObjectArgument(), Env); + return diagnoseUnwrapCall(E->getImplicitObjectArgument(), Env); }) // optional::operator*, optional::operator-> - .CaseOfCFGStmt( - valueOperatorCall(IgnorableOptional), - [](const CallExpr *E, const MatchFinder::MatchResult &, - const Environment &Env) { - return diagnoseUnwrapCall(E, E->getArg(0), Env); - }) + .CaseOfCFGStmt(valueOperatorCall(IgnorableOptional), + [](const CallExpr *E, + const MatchFinder::MatchResult &, + const Environment &Env) { + return diagnoseUnwrapCall(E->getArg(0), Env); + }) .Build(); } -- 2.7.4