From 69e44c24e3bd946390585a123c73aac9a6653709 Mon Sep 17 00:00:00 2001 From: Cedric BAIL Date: Wed, 3 Jun 2015 16:12:01 +0200 Subject: [PATCH] ecore_con: fix error handling case. Since the move to Eo, in case of error we do not need to cleanup anything when finalize finish. The kill function was arranged to do so, but it was still emiting an event exposing the invalid Eo object. Looking closely at the code, that should have not happened, as there was no symetrical ADD event and the function would do nothing else. So removing it. This prevent any potential SEGV from a function that would catch the DEL event. @fix --- src/lib/ecore_con/ecore_con.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/lib/ecore_con/ecore_con.c b/src/lib/ecore_con/ecore_con.c index bc121d3..941dc11 100644 --- a/src/lib/ecore_con/ecore_con.c +++ b/src/lib/ecore_con/ecore_con.c @@ -541,8 +541,6 @@ _ecore_con_connector_eo_base_finalize(Ecore_Con_Server *obj, void *pd EINA_UNUSE return obj; error: - if (svr->delete_me) return NULL; - _ecore_con_server_kill(obj); return NULL; } -- 2.7.4