From 6936240e66f9641073c9a399bb1c0e20bbde7f97 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 15 Nov 2010 08:34:00 +0000 Subject: [PATCH] bfd: bfin: drop needless symbol flag handling imported from FRV The Blackfin bfd merged some FRV code recently, and then removed pieces that didn't make sense. In the FRV code, it outputs a "_gp" symbol in its BFD whereas in the Blackfin code, we don't. So while on the FRV side it fiddles with the "flags" variable (sometimes using it for section flags and sometimes using it for symbol flags), we don't need any of that. This lead to BZ 12177 where the Blackfin code is a bit confusing. So to fix things up, remove more stuff we don't need. Shouldn't change the behavior at all. Signed-off-by: Mike Frysinger --- bfd/ChangeLog | 5 +++++ bfd/elf32-bfin.c | 6 ------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 35aae25..596c577 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2010-11-15 Mike Frysinger + + PR binutils/12177 + * elf32-bfin.c (_bfin_create_got_section): Drop unused flags code. + 2010-11-12 H.J. Lu * archive.c (_bfd_get_elt_at_filepos): Copy BFD_COMPRESS and diff --git a/bfd/elf32-bfin.c b/bfd/elf32-bfin.c index 237391b..38f31e4 100644 --- a/bfd/elf32-bfin.c +++ b/bfd/elf32-bfin.c @@ -3442,14 +3442,8 @@ _bfin_create_got_section (bfd *abfd, struct bfd_link_info *info) return FALSE; bfinfdpic_gotfixup_section (info) = s; - flags = BSF_GLOBAL; - } - else - { - flags = BSF_GLOBAL | BSF_WEAK; } - flags = pltflags; pltflags |= SEC_CODE; if (bed->plt_not_loaded) pltflags &= ~ (SEC_CODE | SEC_LOAD | SEC_HAS_CONTENTS); -- 2.7.4