From 68ec631db73c52d9006ac46ecd1437fc2e0adc34 Mon Sep 17 00:00:00 2001 From: Rajat Verma Date: Mon, 19 Oct 2015 15:32:19 +0530 Subject: [PATCH] playsink: relink text_pad in case of reconfiguration In case of reconfiguration, text_pad should be re-connected with stream synchronizer sink pad. Otherwise we'll leave an unlinked pad around if there always was a streamsynchronizer text pad. https://bugzilla.gnome.org/show_bug.cgi?id=756804 --- gst/playback/gstplaysink.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gst/playback/gstplaysink.c b/gst/playback/gstplaysink.c index 1685692..6512493 100644 --- a/gst/playback/gstplaysink.c +++ b/gst/playback/gstplaysink.c @@ -3700,13 +3700,13 @@ gst_play_sink_do_reconfigure (GstPlaySink * playsink) g_value_unset (&item); g_assert (playsink->text_srcpad_stream_synchronizer); gst_iterator_free (it); - - gst_ghost_pad_set_target (GST_GHOST_PAD_CAST (playsink->text_pad), - playsink->text_sinkpad_stream_synchronizer); - gst_pad_link_full (playsink->text_srcpad_stream_synchronizer, - playsink->textchain->textsinkpad, GST_PAD_LINK_CHECK_NOTHING); } + gst_ghost_pad_set_target (GST_GHOST_PAD_CAST (playsink->text_pad), + playsink->text_sinkpad_stream_synchronizer); + gst_pad_link_full (playsink->text_srcpad_stream_synchronizer, + playsink->textchain->textsinkpad, GST_PAD_LINK_CHECK_NOTHING); + if (need_vis || need_video) { if (need_vis) { GstPad *srcpad; -- 2.7.4