From 68c0188ea77891266c048d0768250eba51441cb2 Mon Sep 17 00:00:00 2001 From: Arnaldo Carvalho de Melo Date: Tue, 22 Jan 2019 11:14:55 -0200 Subject: [PATCH] perf symbols: Remove some unnecessary includes from symbol.h And fixup the fallout in places like annotation and jitdump that were using things like dirname() but weren't including libgen.h, etc. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Link: https://lkml.kernel.org/n/tip-wrii9hy1a1wathc0398f9fgt@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/annotate.c | 1 + tools/perf/util/dso.c | 1 + tools/perf/util/jitdump.c | 1 + tools/perf/util/symbol-minimal.c | 1 + tools/perf/util/symbol.h | 10 ++++------ 5 files changed, 8 insertions(+), 6 deletions(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 70de8f6..3d79add 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -9,6 +9,7 @@ #include #include +#include #include "util.h" #include "ui/ui.h" #include "sort.h" diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index 62c8cf6..1b17f6d 100644 --- a/tools/perf/util/dso.c +++ b/tools/perf/util/dso.c @@ -8,6 +8,7 @@ #include #include #include +#include #include "compress.h" #include "path.h" #include "symbol.h" diff --git a/tools/perf/util/jitdump.c b/tools/perf/util/jitdump.c index bf24955..eda28d3 100644 --- a/tools/perf/util/jitdump.c +++ b/tools/perf/util/jitdump.c @@ -2,6 +2,7 @@ #include #include #include +#include #include #include #include diff --git a/tools/perf/util/symbol-minimal.c b/tools/perf/util/symbol-minimal.c index 7119df7..17edbd4 100644 --- a/tools/perf/util/symbol-minimal.c +++ b/tools/perf/util/symbol-minimal.c @@ -3,6 +3,7 @@ #include "util.h" #include +#include #include #include #include diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index 956d991..2162a5d 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h @@ -5,16 +5,10 @@ #include #include #include -#include "map.h" -#include "../perf.h" #include #include #include -#include -#include #include "branch.h" -#include "build-id.h" -#include "event.h" #include "path.h" #include "symbol_conf.h" @@ -26,6 +20,10 @@ #include "dso.h" +struct map; +struct map_groups; +struct option; + /* * libelf 0.8.x and earlier do not support ELF_C_READ_MMAP; * for newer versions we can use mmap to reduce memory usage: -- 2.7.4