From 68a6e0c63c76128d403e8ca016c0bcb732ff1b05 Mon Sep 17 00:00:00 2001 From: Yang Yingliang Date: Mon, 25 Oct 2021 13:00:55 +0800 Subject: [PATCH] irqchip/mchp-eic: Fix return value check in mchp_eic_init() In case of error, the function of_iomap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Claudiu Beznea Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20211025050055.1129845-1-yangyingliang@huawei.com --- drivers/irqchip/irq-mchp-eic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-mchp-eic.c b/drivers/irqchip/irq-mchp-eic.c index 09b7a8c..c726a19 100644 --- a/drivers/irqchip/irq-mchp-eic.c +++ b/drivers/irqchip/irq-mchp-eic.c @@ -209,7 +209,7 @@ static int mchp_eic_init(struct device_node *node, struct device_node *parent) return -ENOMEM; eic->base = of_iomap(node, 0); - if (IS_ERR(eic->base)) { + if (!eic->base) { ret = -ENOMEM; goto free; } -- 2.7.4