From 68870ab6ee57a92d140dd2c26b0639fbe84975a6 Mon Sep 17 00:00:00 2001 From: mostynb Date: Thu, 11 Dec 2014 07:27:38 -0800 Subject: [PATCH] move v8_use_external_startup_data to standalone.gypi This allows the setting to be overridable by embedders, at the cost of forcing embedders that don't build v8 using standalone.gypi to add this setting to their build config. BUG=chromium:421063 LOG=Y Review URL: https://codereview.chromium.org/794583002 Cr-Commit-Position: refs/heads/master@{#25781} --- build/features.gypi | 4 ---- build/standalone.gypi | 6 ++++++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/build/features.gypi b/build/features.gypi index c5b7c42..25041ce 100644 --- a/build/features.gypi +++ b/build/features.gypi @@ -59,10 +59,6 @@ # Enable compiler warnings when using V8_DEPRECATED apis. 'v8_deprecation_warnings%': 0, - # Use external files for startup data blobs: - # the JS builtins sources and the start snapshot. - 'v8_use_external_startup_data%': 0, - # Set to 1 to enable DCHECKs in release builds. 'dcheck_always_on%': 0, }, diff --git a/build/standalone.gypi b/build/standalone.gypi index 76fa719..f618a06 100644 --- a/build/standalone.gypi +++ b/build/standalone.gypi @@ -93,6 +93,12 @@ # near-release speeds. 'v8_optimized_debug%': 0, + # Use external files for startup data blobs: + # the JS builtins sources and the start snapshot. + # Embedders that don't use standalone.gypi will need to add + # their own default value. + 'v8_use_external_startup_data%': 0, + # Relative path to icu.gyp from this file. 'icu_gyp_path': '../third_party/icu/icu.gyp', -- 2.7.4