From 6880149e5a78962a055720981d37e5069f296ef7 Mon Sep 17 00:00:00 2001 From: Xu Jia Date: Wed, 24 Mar 2021 15:20:31 +0800 Subject: [PATCH] applicom: fix some err codes returned by ac_ioctl When cmd > 6 or copy_to_user() fail, The variable 'ret' would not be returned back. Fix the 'ret' set but not used. Reviewed-by: Arnd Bergmann Signed-off-by: Xu Jia Link: https://lore.kernel.org/r/20210324072031.941791-1-xujia39@huawei.com Signed-off-by: Greg Kroah-Hartman --- drivers/char/applicom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c index 14b2d80..0ab7651 100644 --- a/drivers/char/applicom.c +++ b/drivers/char/applicom.c @@ -839,7 +839,7 @@ static long ac_ioctl(struct file *file, unsigned int cmd, unsigned long arg) Dummy = readb(apbs[IndexCard].RamIO + VERS); kfree(adgl); mutex_unlock(&ac_mutex); - return 0; + return ret; err: if (warncount) { -- 2.7.4