From 6835e37cec0efb84cdaa476a1447aa7a2bec6432 Mon Sep 17 00:00:00 2001 From: Dmitri Gribenko Date: Sun, 27 Jan 2013 21:28:24 +0000 Subject: [PATCH] Decl printer: fix CXXConstructExpr with implicit default argument Patch by Will Wilson. llvm-svn: 173630 --- clang/lib/AST/DeclPrinter.cpp | 10 +++++++--- clang/test/SemaCXX/ast-print.cpp | 21 +++++++++++++++++++++ 2 files changed, 28 insertions(+), 3 deletions(-) diff --git a/clang/lib/AST/DeclPrinter.cpp b/clang/lib/AST/DeclPrinter.cpp index b400522..6057f60 100644 --- a/clang/lib/AST/DeclPrinter.cpp +++ b/clang/lib/AST/DeclPrinter.cpp @@ -646,9 +646,13 @@ void DeclPrinter::VisitVarDecl(VarDecl *D) { Expr *Init = D->getInit(); if (!Policy.SuppressInitializers && Init) { bool ImplicitInit = false; - if (CXXConstructExpr *Construct = dyn_cast(Init)) - ImplicitInit = D->getInitStyle() == VarDecl::CallInit && - Construct->getNumArgs() == 0 && !Construct->isListInitialization(); + if (CXXConstructExpr *Construct = dyn_cast(Init)) { + if (D->getInitStyle() == VarDecl::CallInit && + !Construct->isListInitialization()) { + ImplicitInit = Construct->getNumArgs() == 0 || + Construct->getArg(0)->isDefaultArgument(); + } + } if (!ImplicitInit) { if ((D->getInitStyle() == VarDecl::CallInit) && !isa(Init)) Out << "("; diff --git a/clang/test/SemaCXX/ast-print.cpp b/clang/test/SemaCXX/ast-print.cpp index d41c347..9ce1f8d 100644 --- a/clang/test/SemaCXX/ast-print.cpp +++ b/clang/test/SemaCXX/ast-print.cpp @@ -99,3 +99,24 @@ int test11() { return test10::M::X::value; } + +struct DefaultArgClass +{ + DefaultArgClass(int a = 1) {} +}; + +struct NoArgClass +{ + NoArgClass() {} +}; + +// CHECK: test12 +// CHECK-NEXT: DefaultArgClass useDefaultArg; +// CHECK-NEXT: DefaultArgClass overrideDefaultArg(1); +// CHECK-NEXT: NoArgClass noArg; +void test12() { + DefaultArgClass useDefaultArg; + DefaultArgClass overrideDefaultArg(1); + NoArgClass noArg; +} + -- 2.7.4