From 681c15eb4e541255af1d7e1dd4e634913f26565c Mon Sep 17 00:00:00 2001 From: "yurys@chromium.org" Date: Tue, 1 Apr 2014 11:23:23 +0000 Subject: [PATCH] Remove debugger_auto_break flag The flag was introduced to support console debugger in Chrome. That debugger was replaced by DevTools long time ago and the flag is always true now. BUG=None LOG=Y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/220743003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20393 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- include/v8-debug.h | 2 +- src/execution.cc | 8 +++----- src/flag-definitions.h | 3 --- test/cctest/test-debug.cc | 5 ----- 4 files changed, 4 insertions(+), 14 deletions(-) diff --git a/include/v8-debug.h b/include/v8-debug.h index 1a86a06..0199cd2 100644 --- a/include/v8-debug.h +++ b/include/v8-debug.h @@ -290,7 +290,7 @@ class V8_EXPORT Debug { * * Generally when message arrives V8 may be in one of 3 states: * 1. V8 is running script; V8 will automatically interrupt and process all - * pending messages (however auto_break flag should be enabled); + * pending messages; * 2. V8 is suspended on debug breakpoint; in this state V8 is dedicated * to reading and processing debug messages; * 3. V8 is not running at all or has called some long-working C++ function; diff --git a/src/execution.cc b/src/execution.cc index da07d0f..2e16413 100644 --- a/src/execution.cc +++ b/src/execution.cc @@ -519,11 +519,9 @@ bool StackGuard::IsDebugCommand() { void StackGuard::DebugCommand() { - if (FLAG_debugger_auto_break) { - ExecutionAccess access(isolate_); - thread_local_.interrupt_flags_ |= DEBUGCOMMAND; - set_interrupt_limits(access); - } + ExecutionAccess access(isolate_); + thread_local_.interrupt_flags_ |= DEBUGCOMMAND; + set_interrupt_limits(access); } #endif diff --git a/src/flag-definitions.h b/src/flag-definitions.h index 3f0f7ec..f3eaac8 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -471,9 +471,6 @@ DEFINE_bool(trace_array_abuse, false, "trace out-of-bounds accesses to all arrays") DEFINE_implication(trace_array_abuse, trace_js_array_abuse) DEFINE_implication(trace_array_abuse, trace_external_array_abuse) -DEFINE_bool(debugger_auto_break, true, - "automatically set the debug break flag when debugger commands are " - "in the queue") DEFINE_bool(enable_liveedit, true, "enable liveedit experimental feature") DEFINE_bool(hard_abort, true, "abort by crashing") diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc index b51cb77..bf3e223 100644 --- a/test/cctest/test-debug.cc +++ b/test/cctest/test-debug.cc @@ -5409,8 +5409,6 @@ void BreakpointsDebuggerThread::Run() { void TestRecursiveBreakpointsGeneric(bool global_evaluate) { - i::FLAG_debugger_auto_break = true; - BreakpointsDebuggerThread breakpoints_debugger_thread(global_evaluate); BreakpointsV8Thread breakpoints_v8_thread; @@ -5881,7 +5879,6 @@ void HostDispatchDebuggerThread::Run() { TEST(DebuggerHostDispatch) { HostDispatchDebuggerThread host_dispatch_debugger_thread; HostDispatchV8Thread host_dispatch_v8_thread; - i::FLAG_debugger_auto_break = true; // Create a V8 environment Barriers stack_allocated_host_dispatch_barriers; @@ -5948,8 +5945,6 @@ TEST(DebuggerDebugMessageDispatch) { DebugMessageDispatchDebuggerThread debug_message_dispatch_debugger_thread; DebugMessageDispatchV8Thread debug_message_dispatch_v8_thread; - i::FLAG_debugger_auto_break = true; - // Create a V8 environment Barriers stack_allocated_debug_message_dispatch_barriers; debug_message_dispatch_barriers = -- 2.7.4