From 67a633a71796146cfa5984bb2064d9ebd9808fb5 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Wed, 31 Oct 2018 10:41:12 +0000 Subject: [PATCH] [lldb] Fix race condition in framework installation We need the install-liblldb-stripped target to depend on the lldb-framework target in order for the installation to be guaranteed to behave correctly, otherwise it's possible for the lldb-framework and install-liblldb-stripped targets to run in parallel, resulting in temporary or partially processed files being copied into the framework. install-liblldb already depends on lldb-framework for this reason. Differential Revision: https://reviews.llvm.org/D53917 llvm-svn: 345711 --- lldb/cmake/modules/AddLLDB.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake index f04df78..0e26db5 100644 --- a/lldb/cmake/modules/AddLLDB.cmake +++ b/lldb/cmake/modules/AddLLDB.cmake @@ -79,7 +79,7 @@ function(add_lldb_library name) # framework, so it must rely on the framework being fully built first. if (LLDB_BUILD_FRAMEWORK AND ${name} STREQUAL "liblldb") add_dependencies(install-${name} lldb-framework) - add_dependencies(install-lldb-framework-stripped lldb-framework) + add_dependencies(install-${name}-stripped lldb-framework) endif() endif() endif() -- 2.7.4