From 6780cea6281e723a43605998d995acfeab4a4d60 Mon Sep 17 00:00:00 2001
From: Rui Ueyama <ruiu@google.com>
Date: Thu, 5 Mar 2015 20:22:14 +0000
Subject: [PATCH] Early return. NFC.

llvm-svn: 231403
---
 lld/lib/Core/Resolver.cpp | 61 +++++++++++++++++++++++------------------------
 1 file changed, 30 insertions(+), 31 deletions(-)

diff --git a/lld/lib/Core/Resolver.cpp b/lld/lib/Core/Resolver.cpp
index 8b86f59..53cb6e8 100644
--- a/lld/lib/Core/Resolver.cpp
+++ b/lld/lib/Core/Resolver.cpp
@@ -441,39 +441,38 @@ bool Resolver::checkUndefines() {
         undefinedAtoms.end());
   }
 
-  // error message about missing symbols
-  if (!undefinedAtoms.empty()) {
-    // FIXME: need diagnostics interface for writing error messages
-    bool foundUndefines = false;
-    for (const UndefinedAtom *undef : undefinedAtoms) {
-      // Skip over a weak symbol.
-      if (undef->canBeNull() != UndefinedAtom::canBeNullNever)
-        continue;
-
-      // If this is a library and undefined symbols are allowed on the
-      // target platform, skip over it.
-      if (isa<SharedLibraryFile>(undef->file()) && _ctx.allowShlibUndefines())
-        continue;
-
-      // If the undefine is coalesced away, skip over it.
-      if (_symbolTable.isCoalescedAway(undef))
-        continue;
-
-      // Seems like this symbol is undefined. Warn that.
-      foundUndefines = true;
-      if (_ctx.printRemainingUndefines()) {
-        llvm::errs() << "Undefined symbol: " << undef->file().path()
-                     << ": " << _ctx.demangle(undef->name())
-                     << "\n";
-      }
-    }
-    if (foundUndefines) {
-      if (_ctx.printRemainingUndefines())
-        llvm::errs() << "symbol(s) not found\n";
-      return true;
+  if (undefinedAtoms.empty())
+    return false;
+
+  // Warn about unresolved symbols.
+  bool foundUndefines = false;
+  for (const UndefinedAtom *undef : undefinedAtoms) {
+    // Skip over a weak symbol.
+    if (undef->canBeNull() != UndefinedAtom::canBeNullNever)
+      continue;
+
+    // If this is a library and undefined symbols are allowed on the
+    // target platform, skip over it.
+    if (isa<SharedLibraryFile>(undef->file()) && _ctx.allowShlibUndefines())
+      continue;
+
+    // If the undefine is coalesced away, skip over it.
+    if (_symbolTable.isCoalescedAway(undef))
+      continue;
+
+    // Seems like this symbol is undefined. Warn that.
+    foundUndefines = true;
+    if (_ctx.printRemainingUndefines()) {
+      llvm::errs() << "Undefined symbol: " << undef->file().path()
+                   << ": " << _ctx.demangle(undef->name())
+                   << "\n";
     }
   }
-  return false;
+  if (!foundUndefines)
+    return false;
+  if (_ctx.printRemainingUndefines())
+    llvm::errs() << "symbol(s) not found\n";
+  return true;
 }
 
 // remove from _atoms all coaleseced away atoms
-- 
2.7.4