From 67112853c2f76f08638e3e9099297710babe8033 Mon Sep 17 00:00:00 2001 From: Alexander Kornienko Date: Thu, 15 Mar 2018 08:27:42 +0000 Subject: [PATCH] [clang-tidy] rename_check.py misc-unused-raii bugprone-unused-raii --check_class_name=UnusedRAIICheck llvm-svn: 327610 --- .../clang-tidy/bugprone/BugproneTidyModule.cpp | 3 +++ clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt | 1 + .../UnusedRaiiCheck.cpp} | 12 ++++++------ .../UnusedRAIICheck.h => bugprone/UnusedRaiiCheck.h} | 18 +++++++++--------- clang-tools-extra/clang-tidy/misc/CMakeLists.txt | 1 - clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp | 2 -- clang-tools-extra/docs/ReleaseNotes.rst | 11 +++++++---- .../{misc-unused-raii.rst => bugprone-unused-raii.rst} | 6 +++--- clang-tools-extra/docs/clang-tidy/checks/list.rst | 2 +- .../{misc-unused-raii.cpp => bugprone-unused-raii.cpp} | 2 +- 10 files changed, 31 insertions(+), 27 deletions(-) rename clang-tools-extra/clang-tidy/{misc/UnusedRAIICheck.cpp => bugprone/UnusedRaiiCheck.cpp} (92%) rename clang-tools-extra/clang-tidy/{misc/UnusedRAIICheck.h => bugprone/UnusedRaiiCheck.h} (57%) rename clang-tools-extra/docs/clang-tidy/checks/{misc-unused-raii.rst => bugprone-unused-raii.rst} (89%) rename clang-tools-extra/test/clang-tidy/{misc-unused-raii.cpp => bugprone-unused-raii.cpp} (96%) diff --git a/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp b/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp index ac218d7..5849da2 100644 --- a/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp @@ -42,6 +42,7 @@ #include "ThrowKeywordMissingCheck.h" #include "UndefinedMemoryManipulationCheck.h" #include "UndelegatedConstructorCheck.h" +#include "UnusedRaiiCheck.h" #include "UseAfterMoveCheck.h" #include "VirtualNearMissCheck.h" @@ -116,6 +117,8 @@ public: "bugprone-undefined-memory-manipulation"); CheckFactories.registerCheck( "bugprone-undelegated-constructor"); + CheckFactories.registerCheck( + "bugprone-unused-raii"); CheckFactories.registerCheck( "bugprone-use-after-move"); CheckFactories.registerCheck( diff --git a/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt b/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt index 1c8b9b4..9d52852d61 100644 --- a/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt +++ b/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt @@ -34,6 +34,7 @@ add_clang_library(clangTidyBugproneModule ThrowKeywordMissingCheck.cpp UndefinedMemoryManipulationCheck.cpp UndelegatedConstructorCheck.cpp + UnusedRaiiCheck.cpp UseAfterMoveCheck.cpp VirtualNearMissCheck.cpp diff --git a/clang-tools-extra/clang-tidy/misc/UnusedRAIICheck.cpp b/clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp similarity index 92% rename from clang-tools-extra/clang-tidy/misc/UnusedRAIICheck.cpp rename to clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp index e1acfe9..e2882f3 100644 --- a/clang-tools-extra/clang-tidy/misc/UnusedRAIICheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp @@ -1,4 +1,4 @@ -//===--- UnusedRAIICheck.cpp - clang-tidy ---------------------------------===// +//===--- UnusedRaiiCheck.cpp - clang-tidy ---------------------------------===// // // The LLVM Compiler Infrastructure // @@ -7,7 +7,7 @@ // //===----------------------------------------------------------------------===// -#include "UnusedRAIICheck.h" +#include "UnusedRaiiCheck.h" #include "clang/AST/ASTContext.h" #include "clang/Lex/Lexer.h" @@ -15,7 +15,7 @@ using namespace clang::ast_matchers; namespace clang { namespace tidy { -namespace misc { +namespace bugprone { namespace { AST_MATCHER(CXXRecordDecl, hasNonTrivialDestructor) { @@ -24,7 +24,7 @@ AST_MATCHER(CXXRecordDecl, hasNonTrivialDestructor) { } } // namespace -void UnusedRAIICheck::registerMatchers(MatchFinder *Finder) { +void UnusedRaiiCheck::registerMatchers(MatchFinder *Finder) { // Only register the matchers for C++; the functionality currently does not // provide any benefit to other languages, despite being benign. if (!getLangOpts().CPlusPlus) @@ -47,7 +47,7 @@ void UnusedRAIICheck::registerMatchers(MatchFinder *Finder) { this); } -void UnusedRAIICheck::check(const MatchFinder::MatchResult &Result) { +void UnusedRaiiCheck::check(const MatchFinder::MatchResult &Result) { const auto *E = Result.Nodes.getNodeAs("expr"); // We ignore code expanded from macros to reduce the number of false @@ -89,6 +89,6 @@ void UnusedRAIICheck::check(const MatchFinder::MatchResult &Result) { Replacement); } -} // namespace misc +} // namespace bugprone } // namespace tidy } // namespace clang diff --git a/clang-tools-extra/clang-tidy/misc/UnusedRAIICheck.h b/clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.h similarity index 57% rename from clang-tools-extra/clang-tidy/misc/UnusedRAIICheck.h rename to clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.h index 40f44e3..34190ec 100644 --- a/clang-tools-extra/clang-tidy/misc/UnusedRAIICheck.h +++ b/clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.h @@ -1,4 +1,4 @@ -//===--- UnusedRAIICheck.h - clang-tidy -------------------------*- C++ -*-===// +//===--- UnusedRaiiCheck.h - clang-tidy -------------------------*- C++ -*-===// // // The LLVM Compiler Infrastructure // @@ -7,29 +7,29 @@ // //===----------------------------------------------------------------------===// -#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_UNUSEDRAIICHECK_H -#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_UNUSEDRAIICHECK_H +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_UNUSEDRAIICHECK_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_UNUSEDRAIICHECK_H #include "../ClangTidy.h" namespace clang { namespace tidy { -namespace misc { +namespace bugprone { /// Finds temporaries that look like RAII objects. /// /// For the user-facing documentation see: -/// http://clang.llvm.org/extra/clang-tidy/checks/misc-unused-raii.html -class UnusedRAIICheck : public ClangTidyCheck { +/// http://clang.llvm.org/extra/clang-tidy/checks/bugprone-unused-raii.html +class UnusedRaiiCheck : public ClangTidyCheck { public: - UnusedRAIICheck(StringRef Name, ClangTidyContext *Context) + UnusedRaiiCheck(StringRef Name, ClangTidyContext *Context) : ClangTidyCheck(Name, Context) {} void registerMatchers(ast_matchers::MatchFinder *Finder) override; void check(const ast_matchers::MatchFinder::MatchResult &Result) override; }; -} // namespace misc +} // namespace bugprone } // namespace tidy } // namespace clang -#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_UNUSEDRAIICHECK_H +#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_UNUSEDRAIICHECK_H diff --git a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt index e81a528..3806398 100644 --- a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt +++ b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt @@ -13,7 +13,6 @@ add_clang_library(clangTidyMiscModule UniqueptrResetReleaseCheck.cpp UnusedAliasDeclsCheck.cpp UnusedParametersCheck.cpp - UnusedRAIICheck.cpp UnusedUsingDeclsCheck.cpp LINK_LIBS diff --git a/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp b/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp index b49f794..241689a 100644 --- a/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp @@ -21,7 +21,6 @@ #include "UniqueptrResetReleaseCheck.h" #include "UnusedAliasDeclsCheck.h" #include "UnusedParametersCheck.h" -#include "UnusedRAIICheck.h" #include "UnusedUsingDeclsCheck.h" namespace clang { @@ -51,7 +50,6 @@ public: "misc-unused-alias-decls"); CheckFactories.registerCheck( "misc-unused-parameters"); - CheckFactories.registerCheck("misc-unused-raii"); CheckFactories.registerCheck( "misc-unused-using-decls"); } diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index ffb3c45..bcb4c04 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -114,6 +114,11 @@ Improvements to clang-tidy Warns or suggests alternatives if SIMD intrinsics are used which can be replaced by ``std::experimental::simd`` operations. +- New `zircon-temporary-objects + `_ check + + Warns on construction of specific temporary objects in the Zircon kernel. + - New alias `hicpp-avoid-goto `_ to `cppcoreguidelines-avoid-goto `_ @@ -170,10 +175,8 @@ Improvements to clang-tidy - The 'misc-undelegated-constructor' check was renamed to `bugprone-undelegated-constructor `_ -- New `zircon-temporary-objects - `_ check - - Warns on construction of specific temporary objects in the Zircon kernel. +- The 'misc-unused-raii' check was renamed to `bugprone-unused-raii + `_ Improvements to include-fixer ----------------------------- diff --git a/clang-tools-extra/docs/clang-tidy/checks/misc-unused-raii.rst b/clang-tools-extra/docs/clang-tidy/checks/bugprone-unused-raii.rst similarity index 89% rename from clang-tools-extra/docs/clang-tidy/checks/misc-unused-raii.rst rename to clang-tools-extra/docs/clang-tidy/checks/bugprone-unused-raii.rst index d081702..f1987c5 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/misc-unused-raii.rst +++ b/clang-tools-extra/docs/clang-tidy/checks/bugprone-unused-raii.rst @@ -1,7 +1,7 @@ -.. title:: clang-tidy - misc-unused-raii +.. title:: clang-tidy - bugprone-unused-raii -misc-unused-raii -================ +bugprone-unused-raii +==================== Finds temporaries that look like RAII objects. diff --git a/clang-tools-extra/docs/clang-tidy/checks/list.rst b/clang-tools-extra/docs/clang-tidy/checks/list.rst index 9194d62..62ecbb6 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/list.rst +++ b/clang-tools-extra/docs/clang-tidy/checks/list.rst @@ -50,6 +50,7 @@ Clang-Tidy Checks bugprone-throw-keyword-missing bugprone-undefined-memory-manipulation bugprone-undelegated-constructor + bugprone-unused-raii bugprone-use-after-move bugprone-virtual-near-miss cert-dcl03-c (redirects to misc-static-assert) @@ -153,7 +154,6 @@ Clang-Tidy Checks misc-uniqueptr-reset-release misc-unused-alias-decls misc-unused-parameters - misc-unused-raii misc-unused-using-decls modernize-avoid-bind modernize-deprecated-headers diff --git a/clang-tools-extra/test/clang-tidy/misc-unused-raii.cpp b/clang-tools-extra/test/clang-tidy/bugprone-unused-raii.cpp similarity index 96% rename from clang-tools-extra/test/clang-tidy/misc-unused-raii.cpp rename to clang-tools-extra/test/clang-tidy/bugprone-unused-raii.cpp index f22746c..91ade52 100644 --- a/clang-tools-extra/test/clang-tidy/misc-unused-raii.cpp +++ b/clang-tools-extra/test/clang-tidy/bugprone-unused-raii.cpp @@ -1,4 +1,4 @@ -// RUN: %check_clang_tidy %s misc-unused-raii %t +// RUN: %check_clang_tidy %s bugprone-unused-raii %t struct Foo { Foo(); -- 2.7.4