From 6710f773b51f21ad7d10198ca6424bea7faaf9d4 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Tue, 5 Nov 2019 11:36:37 +0100 Subject: [PATCH] USB: idmouse: drop redundant open-count check from release The open count will always be exactly one when release is called, so drop the redundant sanity check. Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191105103638.4929-3-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/idmouse.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/usb/misc/idmouse.c b/drivers/usb/misc/idmouse.c index 0386bac..9b9d5df 100644 --- a/drivers/usb/misc/idmouse.c +++ b/drivers/usb/misc/idmouse.c @@ -278,12 +278,6 @@ static int idmouse_release(struct inode *inode, struct file *file) /* lock our device */ mutex_lock(&dev->lock); - /* are we really open? */ - if (dev->open <= 0) { - mutex_unlock(&dev->lock); - return -ENODEV; - } - --dev->open; if (!dev->present) { -- 2.7.4