From 670481bdeb7a48d2a9f155080052fafca1be863a Mon Sep 17 00:00:00 2001 From: Peter Seiderer Date: Sat, 6 Apr 2019 21:44:35 +0200 Subject: [PATCH] msdkdec: fix error handling in case of unsupported hardware Check the return value of gst_msdk_context_ensure_context and abort in case of failure. https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/945 --- sys/msdk/gstmsdkdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/msdk/gstmsdkdec.c b/sys/msdk/gstmsdkdec.c index 19b6b57..0870cba 100644 --- a/sys/msdk/gstmsdkdec.c +++ b/sys/msdk/gstmsdkdec.c @@ -675,8 +675,9 @@ gst_msdkdec_start (GstVideoDecoder * decoder) gst_msdk_context_add_job_type (thiz->context, GST_MSDK_JOB_DECODER); } } else { - gst_msdk_context_ensure_context (GST_ELEMENT_CAST (thiz), thiz->hardware, - GST_MSDK_JOB_DECODER); + if (!gst_msdk_context_ensure_context (GST_ELEMENT_CAST (thiz), + thiz->hardware, GST_MSDK_JOB_DECODER)) + return FALSE; GST_INFO_OBJECT (thiz, "Creating new context %" GST_PTR_FORMAT, thiz->context); } -- 2.7.4