From 669f5faf84998227b2604d310a7f33ac90189b8c Mon Sep 17 00:00:00 2001 From: Viresh Kumar Date: Thu, 13 Nov 2014 18:14:34 +0530 Subject: [PATCH] greybus: don't set ->dev.driver to NULL when it is already NULL Parent objects of 'dev' are allocated with kzalloc() and so all of their fields are initialized with 0. Hence no need of marking them NULL again. Signed-off-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/connection.c | 1 - drivers/staging/greybus/interface.c | 1 - drivers/staging/greybus/module.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c index bb26157..5373f44 100644 --- a/drivers/staging/greybus/connection.c +++ b/drivers/staging/greybus/connection.c @@ -185,7 +185,6 @@ struct gb_connection *gb_connection_create(struct gb_interface *interface, connection->state = GB_CONNECTION_STATE_DISABLED; connection->dev.parent = &interface->dev; - connection->dev.driver = NULL; connection->dev.bus = &greybus_bus_type; connection->dev.type = &greybus_connection_type; connection->dev.groups = connection_groups; diff --git a/drivers/staging/greybus/interface.c b/drivers/staging/greybus/interface.c index eb63f63..f7f9bfd 100644 --- a/drivers/staging/greybus/interface.c +++ b/drivers/staging/greybus/interface.c @@ -69,7 +69,6 @@ gb_interface_create(struct gb_module *gmod, u8 interface_id) /* Build up the interface device structures and register it with the * driver core */ interface->dev.parent = &gmod->dev; - interface->dev.driver = NULL; interface->dev.bus = &greybus_bus_type; interface->dev.type = &greybus_interface_type; interface->dev.groups = interface_groups; diff --git a/drivers/staging/greybus/module.c b/drivers/staging/greybus/module.c index 9cf98cd..f5d7dc8 100644 --- a/drivers/staging/greybus/module.c +++ b/drivers/staging/greybus/module.c @@ -90,7 +90,6 @@ struct gb_module *gb_module_create(struct greybus_host_device *hd, u8 module_id) spin_unlock_irq(&gb_modules_lock); gmod->dev.parent = hd->parent; - gmod->dev.driver = NULL; gmod->dev.bus = &greybus_bus_type; gmod->dev.type = &greybus_module_type; gmod->dev.groups = greybus_module_groups; -- 2.7.4