From 6633d80afbeecd91d5d786d6fbb32cdb8bc0a567 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Tue, 19 Jul 2016 15:24:50 +0200 Subject: [PATCH] greybus: module: suppress activation error message for dummy interfaces We currently handle dummy interfaces by deactivating them using activation error paths, but we don't want the corresponding module_inserted error message to be printed. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/module.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/module.c b/drivers/staging/greybus/module.c index 7f0ed9f..242be49 100644 --- a/drivers/staging/greybus/module.c +++ b/drivers/staging/greybus/module.c @@ -153,8 +153,11 @@ static void gb_module_register_interface(struct gb_interface *intf) break; } if (ret) { - dev_err(&module->dev, "failed to activate interface %u: %d\n", - intf_id, ret); + if (intf->type != GB_SVC_INTF_TYPE_DUMMY) { + dev_err(&module->dev, + "failed to activate interface %u: %d\n", + intf_id, ret); + } /* * -EAGAIN indicates that the Greybus operation -- 2.7.4