From 662fcc63638a14faddd2bc89ca5916e592b7a4fc Mon Sep 17 00:00:00 2001 From: "m.m.capewell@googlemail.com" Date: Fri, 29 Nov 2013 13:21:43 +0000 Subject: [PATCH] ARM: Optimize NumberTagU Optimize register constaints for NumberTagU Lithium instruction, and adjust code generated to match. TEST=none BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/94983002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18162 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/arm/lithium-arm.cc | 2 +- src/arm/lithium-codegen-arm.cc | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/arm/lithium-arm.cc b/src/arm/lithium-arm.cc index 7c1f65f..7b605f7 100644 --- a/src/arm/lithium-arm.cc +++ b/src/arm/lithium-arm.cc @@ -2016,7 +2016,7 @@ LInstruction* LChunkBuilder::DoChange(HChange* instr) { LOperand* value = UseRegisterAtStart(val); if (val->CheckFlag(HInstruction::kUint32)) { LNumberTagU* result = new(zone()) LNumberTagU(value); - return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result))); + return AssignEnvironment(AssignPointerMap(DefineAsRegister(result))); } else if (val->HasRange() && val->range()->IsInSmiRange()) { return DefineAsRegister(new(zone()) LSmiTag(value)); } else { diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc index 5aebada..4e1cc2f 100644 --- a/src/arm/lithium-codegen-arm.cc +++ b/src/arm/lithium-codegen-arm.cc @@ -4762,14 +4762,13 @@ void LCodeGen::DoNumberTagU(LNumberTagU* instr) { LNumberTagU* instr_; }; - LOperand* input = instr->value(); - ASSERT(input->IsRegister() && input->Equals(instr->result())); - Register reg = ToRegister(input); + Register input = ToRegister(instr->value()); + Register result = ToRegister(instr->result()); DeferredNumberTagU* deferred = new(zone()) DeferredNumberTagU(this, instr); - __ cmp(reg, Operand(Smi::kMaxValue)); + __ cmp(input, Operand(Smi::kMaxValue)); __ b(hi, deferred->entry()); - __ SmiTag(reg, reg); + __ SmiTag(result, input); __ bind(deferred->exit()); } -- 2.7.4