From 65eb16178d78ef09861a4116d631efa02cf93a93 Mon Sep 17 00:00:00 2001 From: mstarzinger Date: Wed, 21 Jan 2015 06:33:44 -0800 Subject: [PATCH] Add missing FrameState to JSTypedLoweringTester. R=titzer@chromium.org TEST=cctest/test-js-typed-lowering/JSToNumberOfNumberOrOtherPrimitive Review URL: https://codereview.chromium.org/862963002 Cr-Commit-Position: refs/heads/master@{#26194} --- test/cctest/cctest.status | 1 - test/cctest/compiler/test-js-typed-lowering.cc | 7 ++++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status index 2de99dd..77e2082 100644 --- a/test/cctest/cctest.status +++ b/test/cctest/cctest.status @@ -101,7 +101,6 @@ 'test-api/Regress93759': [PASS, NO_VARIANTS], 'test-debug/DebugBreakOnExceptionInObserveCallback': [PASS, NO_VARIANTS], 'test-object-observe/DeliveryCallbackThrows': [PASS, NO_VARIANTS], - 'test-js-typed-lowering/JSToNumberOfNumberOrOtherPrimitive': [PASS, NO_VARIANTS], # TODO(titzer): Triggers bug in late control reduction. 'test-run-inlining/InlineLoopGuardedEmpty': [SKIP], diff --git a/test/cctest/compiler/test-js-typed-lowering.cc b/test/cctest/compiler/test-js-typed-lowering.cc index e23ad0c..3886786 100644 --- a/test/cctest/compiler/test-js-typed-lowering.cc +++ b/test/cctest/compiler/test-js-typed-lowering.cc @@ -118,7 +118,12 @@ class JSTypedLoweringTester : public HandleAndZoneScope { Node* Unop(const Operator* op, Node* input) { // JS unops also require context, effect, and control - return graph.NewNode(op, input, context(), start(), control()); + if (OperatorProperties::HasFrameStateInput(op)) { + return graph.NewNode(op, input, context(), EmptyFrameState(context()), + start(), control()); + } else { + return graph.NewNode(op, input, context(), start(), control()); + } } Node* UseForEffect(Node* node) { -- 2.7.4