From 65ce3aed2444e0b2a415a2119382c5853272e4d4 Mon Sep 17 00:00:00 2001 From: sooyeon Date: Tue, 6 Sep 2022 10:52:24 +0900 Subject: [PATCH] Fix coverity issues Change-Id: I3db738f369e0a7a36f09e73ca1f9740a79f1b8ef Signed-off-by: sooyeon --- client/vc_mgr_ducking.cpp | 3 ++- client/vc_mgr_tidl.c | 4 ++++ client/vc_setting_tidl.c | 3 +++ server/vcd_tidl.c | 4 ++++ 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/client/vc_mgr_ducking.cpp b/client/vc_mgr_ducking.cpp index f8e8756..06a2290 100644 --- a/client/vc_mgr_ducking.cpp +++ b/client/vc_mgr_ducking.cpp @@ -68,8 +68,9 @@ static void __destroy_ducking_handle(sound_stream_ducking_h ducking_handle) return; } + SLOG(LOG_WARN, TAG_VCM, "Destroy ducking handle. handle(%p)", ducking_handle); int ret = sound_manager_destroy_stream_ducking(ducking_handle); - SLOG(LOG_WARN, TAG_VCM, "Destroy ducking handle. handle(%p) ret(%d/%s)", ducking_handle, ret, get_error_message(ret)); + SLOG(LOG_WARN, TAG_VCM, "Destroy ducking handle DONE. ret(%d/%s)", ret, get_error_message(ret)); } static bool __is_all_ducking_handle_valid() diff --git a/client/vc_mgr_tidl.c b/client/vc_mgr_tidl.c index 69b51d5..94f3bd9 100644 --- a/client/vc_mgr_tidl.c +++ b/client/vc_mgr_tidl.c @@ -945,6 +945,8 @@ int vc_mgr_tidl_request_get_audio_type(int pid, char** audio_type) if (VC_ERROR_NONE != ret) { SLOG(LOG_ERROR, TAG_VCM, "[TIDL ERROR] Request vc manager get audio type : Fail to invoke message, error(%d)", ret); + *audio_type = NULL; + free(tmp); return ret; } SLOG(LOG_DEBUG, TAG_VCM, "[TIDL] Request vc manager get audio type : Success"); @@ -996,6 +998,8 @@ int vc_mgr_tidl_request_get_private_data(int pid, const char* key, char** data) if (VC_ERROR_NONE != ret) { SLOG(LOG_ERROR, TAG_VCM, "[TIDL ERROR] Request vc manager get private data : Fail to invoke message, error(%d)", ret); + *data = NULL; + free(tmp); return ret; } SLOG(LOG_DEBUG, TAG_VCM, "[TIDL] Request vc manager get private data : Success"); diff --git a/client/vc_setting_tidl.c b/client/vc_setting_tidl.c index 4f33b25..33ec24a 100644 --- a/client/vc_setting_tidl.c +++ b/client/vc_setting_tidl.c @@ -228,6 +228,7 @@ int vc_setting_tidl_open_connection() if (NULL == info->rpc_h) { SLOG(LOG_ERROR, TAG_VCC, "[TIDL ERROR] Fail to create proxy"); free(info); + free(engine_appid); return VC_ERROR_OPERATION_FAILED; } @@ -235,6 +236,8 @@ int vc_setting_tidl_open_connection() g_tidl_infos = g_list_append(g_tidl_infos, info); SLOG(LOG_ERROR, TAG_VCC, "[TIDL] pid(%d) rpc_h(%p), engine_appid(%s)", pid, info->rpc_h, info->engine_appid); + free(engine_appid); + return VC_ERROR_NONE; } diff --git a/server/vcd_tidl.c b/server/vcd_tidl.c index 9025949..e142039 100644 --- a/server/vcd_tidl.c +++ b/server/vcd_tidl.c @@ -850,6 +850,7 @@ static void __vc_mgr_create_cb(rpc_port_stub_vcd_mgr_stub_vc_mgr_context_h conte if (0 != ret) { SLOG(LOG_ERROR, TAG_VCD, "[TIDL ERROR] Fail to create manager tidl info."); + free(sender); pthread_mutex_unlock(&g_mgr_tidl_info_mutex); return; } @@ -858,6 +859,7 @@ static void __vc_mgr_create_cb(rpc_port_stub_vcd_mgr_stub_vc_mgr_context_h conte if (NULL == mgr_tidl_info) { SLOG(LOG_ERROR, TAG_VCD, "[TIDL ERROR] Fail to get manager tidl info"); + free(sender); pthread_mutex_unlock(&g_mgr_tidl_info_mutex); return; } @@ -2556,6 +2558,8 @@ int vcdc_send_request_get_private_data(int pid, const char* key, char** data) int ret = rpc_port_proxy_vcd_mgr_proxy_vcd_mgr_invoke_get_private_data(mgr_tidl_info->rpc_h, pid, key, &tmp); if (RPC_PORT_ERROR_NONE != ret) { SLOG(LOG_ERROR, TAG_VCD, "[TIDL ERROR] Request vcd manager get private data : Fail to invoke message, error(%d)", ret); + *data = NULL; + free(tmp); return ret; } SLOG(LOG_DEBUG, TAG_VCD, "[TIDL] Request vcd manager get private data : Success"); -- 2.34.1