From 65aeeae6708269081206624f75163c8df6ddd67c Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Thu, 25 Jul 2019 12:58:59 -0700 Subject: [PATCH] freedreno: Fix helgrind complaint on shader-db key setup. If the variable's going to be static, we shouldn't be memsetting it from every thread and instead just have it in the data section. Reviewed-by: Rob Clark --- src/gallium/drivers/freedreno/ir3/ir3_gallium.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_gallium.c b/src/gallium/drivers/freedreno/ir3/ir3_gallium.c index b94909b..4856296 100644 --- a/src/gallium/drivers/freedreno/ir3/ir3_gallium.c +++ b/src/gallium/drivers/freedreno/ir3/ir3_gallium.c @@ -135,8 +135,7 @@ ir3_shader_create(struct ir3_compiler *compiler, * (as otherwise nothing will trigger the shader to be * actually compiled) */ - static struct ir3_shader_key key; - memset(&key, 0, sizeof(key)); + static struct ir3_shader_key key; /* static is implicitly zeroed */ ir3_shader_variant(shader, key, false, debug); if (nir->info.stage != MESA_SHADER_FRAGMENT) -- 2.7.4