From 65146382b379037f560b30ab661e28d6e00be948 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Wed, 15 Dec 2021 18:39:21 -0500 Subject: [PATCH] [gn build] Remove unhelpful default for goma_dir The default hasn't worked in over 9 months now. Getting a friendly error message if this isn't set is more useful than getting a bad default value. Differential Revision: https://reviews.llvm.org/D115833 --- llvm/utils/gn/build/toolchain/BUILD.gn | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/llvm/utils/gn/build/toolchain/BUILD.gn b/llvm/utils/gn/build/toolchain/BUILD.gn index 9819acd..f48f25c 100644 --- a/llvm/utils/gn/build/toolchain/BUILD.gn +++ b/llvm/utils/gn/build/toolchain/BUILD.gn @@ -3,15 +3,11 @@ import("//llvm/utils/gn/build/toolchain/compiler.gni") declare_args() { # If is_goma is true, the location of the goma client install. # Set this to the output of `goma_ctl goma_dir`. - if (host_os == "win") { - goma_dir = "C:/src/goma/goma-win64" - } else { - goma_dir = getenv("HOME") + "/goma" - } + goma_dir = "" } assert(!use_goma || goma_dir != "", - "set goma_dir to the output of `goma_ctl goma_dir` in your args.gn") + "set `goma_dir` to the output of `goma_ctl goma_dir` in your args.gn") template("unix_toolchain") { toolchain(target_name) { -- 2.7.4