From 650f72ff673646cc74c8420f6e2674aa7d1da309 Mon Sep 17 00:00:00 2001 From: =?utf8?q?=EB=B0=B1=EC=A2=85=EB=AF=BC/Tizen=20Platform=20Lab=28SR=29/?= =?utf8?q?=EC=82=BC=EC=84=B1=EC=A0=84=EC=9E=90?= Date: Tue, 17 Oct 2023 14:16:47 +0900 Subject: [PATCH] refactor: apply for_each to remove repeated code --- src/esplusplayer/src/esplayer.cpp | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/src/esplusplayer/src/esplayer.cpp b/src/esplusplayer/src/esplayer.cpp index 779137b..fc6e940 100644 --- a/src/esplusplayer/src/esplayer.cpp +++ b/src/esplusplayer/src/esplayer.cpp @@ -3007,22 +3007,20 @@ void EsPlayer::InitValuesFromIni_() { namespace es_conf { void LoadIniProperty(const Json::Value& root) { + // clang-format off + std::vector booleanKeys { + "generate_dot", + "force_sw_audio_codec", + "force_sw_video_codec", + "fallback_to_sw_audio_codec", + "fallback_to_sw_video_codec" + }; + // clang-format on gst_util::GstInit(root); - std::string key = "generate_dot"; - es_conf::ini_property[key] = root.get(key, "").asBool(); - LOG_DEBUG("[%s] : [%d]", key.c_str(), es_conf::ini_property[key]); - key = "force_sw_audio_codec"; - es_conf::ini_property[key] = root.get(key, "").asBool(); - LOG_DEBUG("[%s] : [%d]", key.c_str(), es_conf::ini_property[key]); - key = "force_sw_video_codec"; - es_conf::ini_property[key] = root.get(key, "").asBool(); - LOG_DEBUG("[%s] : [%d]", key.c_str(), es_conf::ini_property[key]); - key = "fallback_to_sw_audio_codec"; - es_conf::ini_property[key] = root.get(key, "").asBool(); - LOG_DEBUG("[%s] : [%d]", key.c_str(), es_conf::ini_property[key]); - key = "fallback_to_sw_video_codec"; - es_conf::ini_property[key] = root.get(key, "").asBool(); - LOG_DEBUG("[%s] : [%d]", key.c_str(), es_conf::ini_property[key]); + std::for_each(booleanKeys.begin(), booleanKeys.end(), [&](const auto& key) { + es_conf::ini_property[key] = root.get(key, "").asBool(); + LOG_DEBUG("[%s] : [%d]", key.c_str(), es_conf::ini_property[key]); + }); } bool LoadIniFile() { -- 2.7.4