From 64dc6ab056bed36e21c215c47fb81f26dec3396e Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Fri, 28 Jul 2017 20:39:44 +0900 Subject: [PATCH] evas bmp loader - fix warnings about same type handled twice so a type we handle earlir inan if we re-handle as invalid later. this wouldnt lead to a crash or bugs as the if's would ned to be evaluated in order normally, but it's good to get it right. found by PVS studio --- src/modules/evas/image_loaders/bmp/evas_image_load_bmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/evas/image_loaders/bmp/evas_image_load_bmp.c b/src/modules/evas/image_loaders/bmp/evas_image_load_bmp.c index ccf983e..c14cc4b 100644 --- a/src/modules/evas/image_loaders/bmp/evas_image_load_bmp.c +++ b/src/modules/evas/image_loaders/bmp/evas_image_load_bmp.c @@ -436,7 +436,7 @@ evas_image_load_file_head_bmp(void *loader_data, } else if (header.comp == 4) // jpeg - only printer drivers goto close_file; - else if (header.comp == 3) // png - only printer drivers + else if (header.comp == 5) // png - only printer drivers goto close_file; else goto close_file; @@ -1405,7 +1405,7 @@ evas_image_load_file_data_bmp(void *loader_data, { goto close_file; } - else if (header.comp == 3) // png - only printer drivers + else if (header.comp == 5) // png - only printer drivers { goto close_file; } -- 2.7.4