From 64a5472ad70c631b2390aaeae025dda2cf24d50a Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Fri, 8 Sep 2023 08:29:38 +0200 Subject: [PATCH] radv: remove useless PIPELINE_CREATE_2_LIBRARY_BIT check for retained shaders VK_PIPELINE_CREATE_2_RETAIN_LINK_TIME_OPTIMIZATION_INFO_BIT_EXT is only allowed for pipeline libs, so VK_PIPELINE_CREATE_2_LIBRARY_BIT_KHR should also be set. Signed-off-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_pipeline_graphics.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline_graphics.c b/src/amd/vulkan/radv_pipeline_graphics.c index 861bcaf..06ca1fa 100644 --- a/src/amd/vulkan/radv_pipeline_graphics.c +++ b/src/amd/vulkan/radv_pipeline_graphics.c @@ -2683,7 +2683,8 @@ radv_graphics_pipeline_compile(struct radv_graphics_pipeline *pipeline, const Vk */ if (fast_linking_enabled || keep_executable_info) { skip_shaders_cache = true; - } else if ((pipeline->base.create_flags & VK_PIPELINE_CREATE_2_LIBRARY_BIT_KHR) && retain_shaders) { + } else if (retain_shaders) { + assert(pipeline->base.create_flags & VK_PIPELINE_CREATE_2_LIBRARY_BIT_KHR); for (uint32_t i = 0; i < MESA_VULKAN_SHADER_STAGES; i++) { if (stages[i].entrypoint && !stages[i].spirv.size) { skip_shaders_cache = true; -- 2.7.4