From 644fab247b8381f744d23b917a5a53a7f8bb44ad Mon Sep 17 00:00:00 2001 From: "jkummerow@chromium.org" Date: Tue, 14 Jan 2014 13:45:43 +0000 Subject: [PATCH] Delete useless --loop-weight flag killing a static variable in the process. BUG=chromium:333871 LOG=N R=ulan@chromium.org Review URL: https://codereview.chromium.org/131223009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18587 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/flag-definitions.h | 1 - src/hydrogen-instructions.cc | 12 ++---------- src/hydrogen-instructions.h | 1 - 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/src/flag-definitions.h b/src/flag-definitions.h index 93adb62..c96baee 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -322,7 +322,6 @@ DEFINE_bool(flush_optimized_code_cache, true, DEFINE_bool(inline_construct, true, "inline constructor calls") DEFINE_bool(inline_arguments, true, "inline functions with arguments object") DEFINE_bool(inline_accessors, true, "inline JavaScript accessors") -DEFINE_int(loop_weight, 1, "loop weight for representation inference") DEFINE_int(escape_analysis_iterations, 2, "maximum number of escape analysis fix-point iterations") diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc index 2060d2e..5256169 100644 --- a/src/hydrogen-instructions.cc +++ b/src/hydrogen-instructions.cc @@ -54,14 +54,6 @@ HYDROGEN_CONCRETE_INSTRUCTION_LIST(DEFINE_COMPILE) #undef DEFINE_COMPILE -int HValue::LoopWeight() const { - const int w = FLAG_loop_weight; - static const int weights[] = { 1, w, w*w, w*w*w, w*w*w*w }; - return weights[Min(block()->LoopNestingDepth(), - static_cast(ARRAY_SIZE(weights)-1))]; -} - - Isolate* HValue::isolate() const { ASSERT(block() != NULL); return block()->isolate(); @@ -106,7 +98,7 @@ Representation HValue::RepresentationFromUses() { id(), Mnemonic(), use->id(), use->Mnemonic(), rep.Mnemonic(), (use->CheckFlag(kTruncatingToInt32) ? "-trunc" : "")); } - use_count[rep.kind()] += use->LoopWeight(); + use_count[rep.kind()] += 1; } if (IsPhi()) HPhi::cast(this)->AddIndirectUsesTo(&use_count[0]); int tagged_count = use_count[Representation::kTagged]; @@ -2357,7 +2349,7 @@ void HPhi::InitRealUses(int phi_id) { HValue* value = it.value(); if (!value->IsPhi()) { Representation rep = value->observed_input_representation(it.index()); - non_phi_uses_[rep.kind()] += value->LoopWeight(); + non_phi_uses_[rep.kind()] += 1; if (FLAG_trace_representation) { PrintF("#%d Phi is used by real #%d %s as %s\n", id(), value->id(), value->Mnemonic(), rep.Mnemonic()); diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h index 363618d..af6729a 100644 --- a/src/hydrogen-instructions.h +++ b/src/hydrogen-instructions.h @@ -645,7 +645,6 @@ class HValue : public ZoneObject { HBasicBlock* block() const { return block_; } void SetBlock(HBasicBlock* block); - int LoopWeight() const; // Note: Never call this method for an unlinked value. Isolate* isolate() const; -- 2.7.4