From 64420d0dad7f104a674beb20cf3622ce16388536 Mon Sep 17 00:00:00 2001 From: Jarkko Hietaniemi Date: Thu, 2 Aug 2001 14:24:26 +0000 Subject: [PATCH] Readability nit from Abhijit. p4raw-id: //depot/perl@11552 --- op.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/op.c b/op.c index 3e0d685..7fad9a4 100644 --- a/op.c +++ b/op.c @@ -2210,9 +2210,14 @@ Perl_localize(pTHX_ OP *o, I32 lex) if (o->op_flags & OPf_PARENS) list(o); else { - if (ckWARN(WARN_PARENTHESIS) && PL_bufptr > PL_oldbufptr && PL_bufptr[-1] == ',') { - char *s; - for (s = PL_bufptr; *s && (isALNUM(*s) || UTF8_IS_CONTINUED(*s) || strchr("@$%, ",*s)); s++) ; + if (ckWARN(WARN_PARENTHESIS) + && PL_bufptr > PL_oldbufptr && PL_bufptr[-1] == ',') + { + char *s = PL_bufptr; + + while (*s && (isALNUM(*s) || UTF8_IS_CONTINUED(*s) || strchr("@$%, ", *s))) + s++; + if (*s == ';' || *s == '=') Perl_warner(aTHX_ WARN_PARENTHESIS, "Parentheses missing around \"%s\" list", -- 2.7.4