From 63e72aa4f575bf2a3405fb7c5e4450efe2ee3e4f Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 4 Nov 2020 08:20:46 -0800 Subject: [PATCH] [MLIR] Remove NoSideEffect from std.global_memref op. - Also spell "isUninitialized" correctly. Differential Revision: https://reviews.llvm.org/D90768 --- mlir/include/mlir/Dialect/StandardOps/IR/Ops.td | 4 ++-- mlir/lib/Dialect/StandardOps/IR/Ops.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td b/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td index 999119f..e88cb65 100644 --- a/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td +++ b/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td @@ -2009,7 +2009,7 @@ def FPTruncOp : CastOp<"fptrunc">, Arguments<(ins AnyType:$in)> { // GlobalMemrefOp //===----------------------------------------------------------------------===// -def GlobalMemrefOp : Std_Op<"global_memref", [NoSideEffect, Symbol]> { +def GlobalMemrefOp : Std_Op<"global_memref", [Symbol]> { let summary = "declare or define a global memref variable"; let description = [{ The `global_memref` operation declares or defines a named global variable. @@ -2062,7 +2062,7 @@ def GlobalMemrefOp : Std_Op<"global_memref", [NoSideEffect, Symbol]> { let extraClassDeclaration = [{ bool isExternal() { return !initial_value(); } - bool isUnitialized() { + bool isUninitialized() { return !isExternal() && initial_value().getValue().isa(); } }]; diff --git a/mlir/lib/Dialect/StandardOps/IR/Ops.cpp b/mlir/lib/Dialect/StandardOps/IR/Ops.cpp index 8c9a1bb..264f934 100644 --- a/mlir/lib/Dialect/StandardOps/IR/Ops.cpp +++ b/mlir/lib/Dialect/StandardOps/IR/Ops.cpp @@ -2169,7 +2169,7 @@ static void printGlobalMemrefOpTypeAndInitialValue(OpAsmPrinter &p, p << type; if (!op.isExternal()) { p << " = "; - if (op.isUnitialized()) + if (op.isUninitialized()) p << "uninitialized"; else p.printAttributeWithoutType(initialValue); -- 2.7.4