From 639b3d1b83bf98fb0d96ba2c8cce1859707a7edf Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Fri, 3 May 2019 18:11:31 +0000 Subject: [PATCH] Remove else-after-return llvm-svn: 359913 --- clang/lib/AST/ExprConstant.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp index 8386ce8..6b3f4dc 100644 --- a/clang/lib/AST/ExprConstant.cpp +++ b/clang/lib/AST/ExprConstant.cpp @@ -8269,17 +8269,16 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E, case Builtin::BI__builtin_constant_p: { const Expr *Arg = E->getArg(0); - if (EvaluateBuiltinConstantP(Info, Arg)) { + if (EvaluateBuiltinConstantP(Info, Arg)) return Success(true, E); - } else if (Info.InConstantContext || Arg->HasSideEffects(Info.Ctx)) { + if (Info.InConstantContext || Arg->HasSideEffects(Info.Ctx)) { // Outside a constant context, eagerly evaluate to false in the presence // of side-effects in order to avoid -Wunsequenced false-positives in // a branch on __builtin_constant_p(expr). return Success(false, E); - } else { - Info.FFDiag(E, diag::note_invalid_subexpr_in_const_expr); - return false; } + Info.FFDiag(E, diag::note_invalid_subexpr_in_const_expr); + return false; } case Builtin::BI__builtin_is_constant_evaluated: -- 2.7.4