From 6359c64336d99060952232e7e300bd3c31afead8 Mon Sep 17 00:00:00 2001 From: Nicholas Clark Date: Tue, 12 Apr 2011 09:01:48 +0100 Subject: [PATCH] In testargs.t in Test::Harness, don't run a world-writable file. The test writes a file, then changes the mode, then executes it. The file needs to be +x to be executable (on many platforms). The file will need to be +w to be deletable on some platforms. But setting the file world writable just before running it feels like a bad idea, given that the file's name is as predictable as process IDs, as there's a race condition to break into the account running perl's tests. --- cpan/Test-Harness/t/testargs.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpan/Test-Harness/t/testargs.t b/cpan/Test-Harness/t/testargs.t index cfbdd58..4fba591 100644 --- a/cpan/Test-Harness/t/testargs.t +++ b/cpan/Test-Harness/t/testargs.t @@ -59,7 +59,7 @@ sub make_shell_test { print $sh "#!$shell\n\n"; print $sh "$^X '$test' \$*\n"; } - chmod 0777, $script; + chmod 0775, $script; return unless -x $script; return [ shell => $script ]; } -- 2.7.4