From 6330653547f492646c92553738dab6a99d7d9710 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 24 Jun 2020 16:18:28 -0700 Subject: [PATCH] [unittest] Fix FrontendTests CanGenerateCC1CommandLineFlag when LLVM_DEFAULT_TARGET_TRIPLE is not normalized after D79796 `TargetOpts->Triple` is initialized as llvm::sys::getDefaultTargetTriple() which may not be normalized. If LLVM_DEFAULT_TARGET_TRIPLE is powerpc64le-linux-gnu, we should check check `-triple powerpc64le-linux-gnu`, instead of (normalized) `-triple powerpc64le-unknown-linux-gnu` --- clang/unittests/Frontend/CompilerInvocationTest.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clang/unittests/Frontend/CompilerInvocationTest.cpp b/clang/unittests/Frontend/CompilerInvocationTest.cpp index ed82d67..9cce66e 100644 --- a/clang/unittests/Frontend/CompilerInvocationTest.cpp +++ b/clang/unittests/Frontend/CompilerInvocationTest.cpp @@ -78,8 +78,7 @@ TEST_F(CC1CommandLineGenerationTest, TEST_F(CC1CommandLineGenerationTest, CanGenerateCC1CommandLineSeparateRequiredAbsent) { - const std::string DefaultTriple = - llvm::Triple::normalize(llvm::sys::getDefaultTargetTriple()); + const std::string DefaultTriple = llvm::sys::getDefaultTargetTriple(); const char *Args[] = {"clang", "-xc++", "-"}; CompilerInvocation CInvok; -- 2.7.4