From 62cb02b7aed30330435c4d63d32c5981b2565a40 Mon Sep 17 00:00:00 2001 From: Bowon Ryu Date: Tue, 24 Aug 2021 11:37:10 +0900 Subject: [PATCH] [NUI] Change SelectionChangedEventArgs to TextSelectionChangedEventArgs (#3451) There is an ambiguous reference problem, because the newly added SelectionChangedEventArgs for Text has the same name as the existing SelectionChangedEventArgs. The SelectionChangedEventArgs for Text is not yet an opened API, so temporarily renaming it to fix the issue. Signed-off-by: Bowon Ryu --- src/Tizen.NUI/src/public/BaseComponents/TextEditorEvent.cs | 8 ++++---- src/Tizen.NUI/src/public/BaseComponents/TextEvent.cs | 2 +- src/Tizen.NUI/src/public/BaseComponents/TextFieldEvent.cs | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/Tizen.NUI/src/public/BaseComponents/TextEditorEvent.cs b/src/Tizen.NUI/src/public/BaseComponents/TextEditorEvent.cs index 3399974..b97c62c 100755 --- a/src/Tizen.NUI/src/public/BaseComponents/TextEditorEvent.cs +++ b/src/Tizen.NUI/src/public/BaseComponents/TextEditorEvent.cs @@ -42,7 +42,7 @@ namespace Tizen.NUI.BaseComponents private EventHandler textEditorAnchorClickedEventHandler; private AnchorClickedCallbackDelegate textEditorAnchorClickedCallbackDelegate; - private EventHandler textEditorSelectionChangedEventHandler; + private EventHandler textEditorSelectionChangedEventHandler; private SelectionChangedCallbackDelegate textEditorSelectionChangedCallbackDelegate; private EventHandler textEditorInputFilteredEventHandler; @@ -203,7 +203,7 @@ namespace Tizen.NUI.BaseComponents /// /// This will be public opened after ACR done. Before ACR, need to be hidden as inhouse API. [EditorBrowsable(EditorBrowsableState.Never)] - public event EventHandler SelectionChanged + public event EventHandler SelectionChanged { add { @@ -390,9 +390,9 @@ namespace Tizen.NUI.BaseComponents { if (textEditorSelectionChangedEventHandler != null) { - SelectionChangedEventArgs e = new SelectionChangedEventArgs(); + TextSelectionChangedEventArgs e = new TextSelectionChangedEventArgs(); - // Populate all members of "e" (SelectionChangedEventArgs) with real data + // Populate all members of "e" (TextSelectionChangedEventArgs) with real data e.OldSelectionStart = oldStart; e.OldSelectionEnd = oldEnd; diff --git a/src/Tizen.NUI/src/public/BaseComponents/TextEvent.cs b/src/Tizen.NUI/src/public/BaseComponents/TextEvent.cs index 38f590f..b351d8d 100644 --- a/src/Tizen.NUI/src/public/BaseComponents/TextEvent.cs +++ b/src/Tizen.NUI/src/public/BaseComponents/TextEvent.cs @@ -66,7 +66,7 @@ namespace Tizen.NUI.BaseComponents /// /// This will be public opened after ACR done. Before ACR, need to be hidden as inhouse API. [EditorBrowsable(EditorBrowsableState.Never)] - public class SelectionChangedEventArgs : EventArgs + public class TextSelectionChangedEventArgs : EventArgs { /// /// selection start before the change. diff --git a/src/Tizen.NUI/src/public/BaseComponents/TextFieldEvent.cs b/src/Tizen.NUI/src/public/BaseComponents/TextFieldEvent.cs index 55f2f33..4bbe79b 100755 --- a/src/Tizen.NUI/src/public/BaseComponents/TextFieldEvent.cs +++ b/src/Tizen.NUI/src/public/BaseComponents/TextFieldEvent.cs @@ -36,7 +36,7 @@ namespace Tizen.NUI.BaseComponents private EventHandler textFieldAnchorClickedEventHandler; private AnchorClickedCallbackDelegate textFieldAnchorClickedCallbackDelegate; - private EventHandler textFieldSelectionChangedEventHandler; + private EventHandler textFieldSelectionChangedEventHandler; private SelectionChangedCallbackDelegate textFieldSelectionChangedCallbackDelegate; private EventHandler textFieldInputFilteredEventHandler; @@ -166,7 +166,7 @@ namespace Tizen.NUI.BaseComponents /// /// This will be public opened after ACR done. Before ACR, need to be hidden as inhouse API. [EditorBrowsable(EditorBrowsableState.Never)] - public event EventHandler SelectionChanged + public event EventHandler SelectionChanged { add { @@ -329,9 +329,9 @@ namespace Tizen.NUI.BaseComponents { if (textFieldSelectionChangedEventHandler != null) { - SelectionChangedEventArgs e = new SelectionChangedEventArgs(); + TextSelectionChangedEventArgs e = new TextSelectionChangedEventArgs(); - // Populate all members of "e" (SelectionChangedEventArgs) with real data + // Populate all members of "e" (TextSelectionChangedEventArgs) with real data e.OldSelectionStart = oldStart; e.OldSelectionEnd = oldEnd; -- 2.7.4