From 62be91708fead9a27bceb829a0762315a147fa8e Mon Sep 17 00:00:00 2001
From: Benjamin Otte <otte@redhat.com>
Date: Sun, 21 Mar 2010 21:39:18 +0100
Subject: [PATCH] Add -Wmissing-declarations -Wmissing-prototypes to configure
 flags

And fix all warnings
---
 gst/quicktime/atoms.c                | 12 ++++++------
 gst/quicktime/atoms.h                |  4 ++--
 gst/quicktime/atomsrecovery.c        |  4 ++--
 gst/quicktime/descriptors.c          |  7 -------
 tests/check/elements/qtmux.c         | 12 ++++++------
 tests/check/pipelines/tagschecking.c |  2 +-
 6 files changed, 17 insertions(+), 24 deletions(-)

diff --git a/gst/quicktime/atoms.c b/gst/quicktime/atoms.c
index 99b02ef..841900d 100644
--- a/gst/quicktime/atoms.c
+++ b/gst/quicktime/atoms.c
@@ -341,15 +341,15 @@ atom_edts_clear (AtomEDTS * edts)
   atom_elst_clear (&edts->elst);
 }
 
-AtomEDTS *
-atom_edts_new ()
+static AtomEDTS *
+atom_edts_new (void)
 {
   AtomEDTS *edts = g_new0 (AtomEDTS, 1);
   atom_edts_init (edts);
   return edts;
 }
 
-void
+static void
 atom_edts_free (AtomEDTS * edts)
 {
   atom_edts_clear (edts);
@@ -3014,7 +3014,7 @@ atom_trak_set_audio_type (AtomTRAK * trak, AtomsContext * context,
   atom_trak_set_constant_size_samples (trak, sample_size);
 }
 
-AtomInfo *
+static AtomInfo *
 build_pasp_extension (AtomTRAK * trak, gint par_width, gint par_height)
 {
   AtomData *atom_data;
@@ -3378,7 +3378,7 @@ build_codec_data_extension (guint32 fourcc, const GstBuffer * codec_data)
 }
 
 AtomInfo *
-build_amr_extension ()
+build_amr_extension (void)
 {
   guint8 ext[9];
   GstBuffer *buf;
@@ -3405,7 +3405,7 @@ build_amr_extension ()
 }
 
 AtomInfo *
-build_h263_extension ()
+build_h263_extension (void)
 {
   guint8 ext[7];
   GstBuffer *buf;
diff --git a/gst/quicktime/atoms.h b/gst/quicktime/atoms.h
index ae167ba..85a41d3 100644
--- a/gst/quicktime/atoms.h
+++ b/gst/quicktime/atoms.h
@@ -731,8 +731,8 @@ AtomInfo *   build_jp2h_extension        (AtomTRAK * trak, gint width, gint heig
 
 AtomInfo *   build_jp2x_extension        (const GstBuffer * prefix);
 AtomInfo *   build_fiel_extension        (gint fields);
-AtomInfo *   build_amr_extension         ();
-AtomInfo *   build_h263_extension        ();
+AtomInfo *   build_amr_extension         (void);
+AtomInfo *   build_h263_extension        (void);
 AtomInfo *   build_gama_atom             (gdouble gamma);
 AtomInfo *   build_SMI_atom              (const GstBuffer *seqh);
 AtomInfo *   build_ima_adpcm_extension   (gint channels, gint rate,
diff --git a/gst/quicktime/atomsrecovery.c b/gst/quicktime/atomsrecovery.c
index 907683e..c9684b1 100644
--- a/gst/quicktime/atomsrecovery.c
+++ b/gst/quicktime/atomsrecovery.c
@@ -794,7 +794,7 @@ moov_recov_parse_buffers (MoovRecovFile * moovrf, MdatRecovFile * mdatrf,
   return TRUE;
 }
 
-guint32
+static guint32
 trak_recov_data_get_trak_atom_size (TrakRecovData * trak)
 {
   AtomSTBL *stbl = &trak->stbl;
@@ -832,7 +832,7 @@ fail:
   return 0;
 }
 
-guint8 *
+static guint8 *
 moov_recov_get_stbl_children_data (MoovRecovFile * moovrf, TrakRecovData * trak,
     guint64 * p_size)
 {
diff --git a/gst/quicktime/descriptors.c b/gst/quicktime/descriptors.c
index f450fce..d1e99c2 100644
--- a/gst/quicktime/descriptors.c
+++ b/gst/quicktime/descriptors.c
@@ -206,13 +206,6 @@ desc_es_descriptor_clear (ESDescriptor * es)
   desc_sl_config_descriptor_clear (&es->sl_conf_desc);
 }
 
-void
-desc_es_descriptor_free (ESDescriptor * es)
-{
-  desc_es_descriptor_clear (es);
-  g_free (es);
-}
-
 /*
  * Size handling functions below
  */
diff --git a/tests/check/elements/qtmux.c b/tests/check/elements/qtmux.c
index bd88b19..0c05818 100644
--- a/tests/check/elements/qtmux.c
+++ b/tests/check/elements/qtmux.c
@@ -56,7 +56,7 @@ static GstStaticPadTemplate srcaudiotemplate = GST_STATIC_PAD_TEMPLATE ("src",
 
 
 /* setup and teardown needs some special handling for muxer */
-GstPad *
+static GstPad *
 setup_src_pad (GstElement * element,
     GstStaticPadTemplate * template, GstCaps * caps, gchar * sinkname)
 {
@@ -86,7 +86,7 @@ setup_src_pad (GstElement * element,
   return srcpad;
 }
 
-void
+static void
 teardown_src_pad (GstPad * srcpad)
 {
   GstPad *sinkpad;
@@ -110,7 +110,7 @@ teardown_src_pad (GstPad * srcpad)
   gst_object_unref (srcpad);
 }
 
-GstElement *
+static GstElement *
 setup_qtmux (GstStaticPadTemplate * srctemplate, gchar * sinkname)
 {
   GstElement *qtmux;
@@ -125,7 +125,7 @@ setup_qtmux (GstStaticPadTemplate * srctemplate, gchar * sinkname)
   return qtmux;
 }
 
-void
+static void
 cleanup_qtmux (GstElement * qtmux, gchar * sinkname)
 {
   GST_DEBUG ("cleanup_qtmux");
@@ -138,7 +138,7 @@ cleanup_qtmux (GstElement * qtmux, gchar * sinkname)
   gst_check_teardown_element (qtmux);
 }
 
-void
+static void
 check_qtmux_pad (GstStaticPadTemplate * srctemplate, gchar * sinkname)
 {
   GstElement *qtmux;
@@ -232,7 +232,7 @@ GST_START_TEST (test_audio_pad)
 GST_END_TEST;
 
 
-Suite *
+static Suite *
 qtmux_suite (void)
 {
   Suite *s = suite_create ("qtmux");
diff --git a/tests/check/pipelines/tagschecking.c b/tests/check/pipelines/tagschecking.c
index 20bdcc8..9aa7ffa 100644
--- a/tests/check/pipelines/tagschecking.c
+++ b/tests/check/pipelines/tagschecking.c
@@ -275,7 +275,7 @@ GST_START_TEST (test_geo_location_tags)
 
 GST_END_TEST;
 
-Suite *
+static Suite *
 metadata_suite (void)
 {
   Suite *s = suite_create ("tagschecking");
-- 
2.7.4