From 62764031e258c200f93f844e813b580f4be9434a Mon Sep 17 00:00:00 2001
From: Seoyeon2Kim <34738918+Seoyeon2Kim@users.noreply.github.com>
Date: Fri, 16 Apr 2021 11:05:38 +0900
Subject: [PATCH] [NUI] Make some of Progress and Slider public methods (#2872)

Public open API list
- Progress : IndeterminateImageUrl
- ProgressStyle : IndeterminateImageUrl
- Slider : ThumbImageUrl, IsValueShown, ValueIndicatorText,
           ValueIndicatorSize, ValueIndicatorUrl, IsDiscrete, DiscreteValue
- SliderStyle : ValueIndicatorText, ValueIndicatorImage

Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
---
 src/Tizen.NUI.Components/Controls/Progress.cs   |  5 +----
 src/Tizen.NUI.Components/Controls/Slider.cs     | 22 +++++++---------------
 src/Tizen.NUI.Components/Style/ProgressStyle.cs |  2 +-
 src/Tizen.NUI.Components/Style/SliderStyle.cs   | 14 ++++++--------
 4 files changed, 15 insertions(+), 28 deletions(-)

diff --git a/src/Tizen.NUI.Components/Controls/Progress.cs b/src/Tizen.NUI.Components/Controls/Progress.cs
index 985d705..d67b524 100755
--- a/src/Tizen.NUI.Components/Controls/Progress.cs
+++ b/src/Tizen.NUI.Components/Controls/Progress.cs
@@ -240,8 +240,7 @@ namespace Tizen.NUI.Components
         /// The property to get/set the indeterminate image.
         /// </summary>
         /// <exception cref="NullReferenceException">Thrown when setting null value.</exception>
-        /// This will be public opened later after ACR done. Before ACR, need to be hidden as inhouse API.
-        [EditorBrowsable(EditorBrowsableState.Never)]
+        /// <since_tizen> 9 </since_tizen>
         public string IndeterminateImageUrl
         {
             get
@@ -446,7 +445,6 @@ namespace Tizen.NUI.Components
         /// <summary>
         /// Change Image status. It can be override.
         /// </summary>
-        /// <since_tizen> 6 </since_tizen>
         /// This needs to be considered more if public-open is necessary.
         [EditorBrowsable(EditorBrowsableState.Never)]
         private void UpdateStates()
@@ -457,7 +455,6 @@ namespace Tizen.NUI.Components
         /// <summary>
         /// Update progress value
         /// </summary>
-        /// <since_tizen> 6 </since_tizen>
         /// This needs to be considered more if public-open is necessary.
         [EditorBrowsable(EditorBrowsableState.Never)]
         private void UpdateValue()
diff --git a/src/Tizen.NUI.Components/Controls/Slider.cs b/src/Tizen.NUI.Components/Controls/Slider.cs
index 871fa92..5460e95 100755
--- a/src/Tizen.NUI.Components/Controls/Slider.cs
+++ b/src/Tizen.NUI.Components/Controls/Slider.cs
@@ -529,8 +529,7 @@ namespace Tizen.NUI.Components
         /// Gets or sets the Url of the thumb image.
         /// </summary>
         /// <exception cref="NullReferenceException">Thrown when setting null value.</exception>
-        /// This will be public opened later after ACR done. Before ACR, need to be hidden as inhouse API.
-        [EditorBrowsable(EditorBrowsableState.Never)]
+        /// <since_tizen> 9 </since_tizen>
         public Selector<string> ThumbImageUrl
         {
             get
@@ -862,8 +861,7 @@ namespace Tizen.NUI.Components
         /// <summary>
         /// Flag to decide whether the value indicator is shown
         /// </summary>
-        /// This will be public opened later after ACR done. Before ACR, need to be hidden as inhouse API.
-        [EditorBrowsable(EditorBrowsableState.Never)]
+        /// <since_tizen> 9 </since_tizen>
         public bool IsValueShown
         {
             get
@@ -879,8 +877,7 @@ namespace Tizen.NUI.Components
         /// <summary>
         /// Gets or sets the text of value indicator.
         /// </summary>
-        /// This will be public opened later after ACR done. Before ACR, need to be hidden as inhouse API.
-        [EditorBrowsable(EditorBrowsableState.Never)]
+        /// <since_tizen> 9 </since_tizen>
         public string ValueIndicatorText
         {
             get
@@ -896,8 +893,7 @@ namespace Tizen.NUI.Components
         /// <summary>
         /// Gets or sets the size of the value indicator image object.
         /// </summary>
-        /// This will be public opened later after ACR done. Before ACR, need to be hidden as inhouse API.
-        [EditorBrowsable(EditorBrowsableState.Never)]
+        /// <since_tizen> 9 </since_tizen>
         public Size ValueIndicatorSize
         {
             get
@@ -916,8 +912,7 @@ namespace Tizen.NUI.Components
         /// <summary>
         /// Gets or sets the resource url of the value indicator image object.
         /// </summary>
-        /// This will be public opened later after ACR done. Before ACR, need to be hidden as inhouse API.
-        [EditorBrowsable(EditorBrowsableState.Never)]
+        /// <since_tizen> 9 </since_tizen>
         public string ValueIndicatorUrl
         {
             get
@@ -938,8 +933,7 @@ namespace Tizen.NUI.Components
         ///
         /// The default value is false.
         /// </summary>
-        /// This will be public opened later after ACR done. Before ACR, need to be hidden as inhouse API.
-        [EditorBrowsable(EditorBrowsableState.Never)]
+        /// <since_tizen> 9 </since_tizen>
         public bool IsDiscrete { get; set; } = false;
 
         /// <summary>
@@ -950,8 +944,7 @@ namespace Tizen.NUI.Components
         /// Then, the thumb can only go to 0, 20, 40, 60, 80, and 100.
         /// The default is 0.
         /// </summary>
-        /// This will be public opened later after ACR done. Before ACR, need to be hidden as inhouse API.
-        [EditorBrowsable(EditorBrowsableState.Never)]
+        /// <since_tizen> 9 </since_tizen>
         public float DiscreteValue
         {
             get
@@ -1304,7 +1297,6 @@ namespace Tizen.NUI.Components
         /// <summary>
         /// Update Slider by style.
         /// </summary>
-        /// <since_tizen> 6 </since_tizen>
         /// This will be public opened later after ACR done. Before ACR, need to be hidden as inhouse API.
         [EditorBrowsable(EditorBrowsableState.Never)]
         protected override void OnUpdate()
diff --git a/src/Tizen.NUI.Components/Style/ProgressStyle.cs b/src/Tizen.NUI.Components/Style/ProgressStyle.cs
index 3d53588..bb47695 100755
--- a/src/Tizen.NUI.Components/Style/ProgressStyle.cs
+++ b/src/Tizen.NUI.Components/Style/ProgressStyle.cs
@@ -66,7 +66,7 @@ namespace Tizen.NUI.Components
         /// <summary>
         /// Gets or sets indeterminate progress resource.
         /// </summary>
-        [EditorBrowsable(EditorBrowsableState.Never)]
+        /// <since_tizen> 9 </since_tizen>
         public string IndeterminateImageUrl { get; set; }
 
         /// <summary>
diff --git a/src/Tizen.NUI.Components/Style/SliderStyle.cs b/src/Tizen.NUI.Components/Style/SliderStyle.cs
index ac459b6..b50d359 100755
--- a/src/Tizen.NUI.Components/Style/SliderStyle.cs
+++ b/src/Tizen.NUI.Components/Style/SliderStyle.cs
@@ -29,7 +29,7 @@ namespace Tizen.NUI.Components
     {
         /// <summary>
         /// IndicatorTypeProperty
-        /// </summary> 
+        /// </summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
         public static readonly BindableProperty IndicatorTypeProperty = BindableProperty.Create(nameof(IndicatorType), typeof(IndicatorType?), typeof(SliderStyle), null, propertyChanged: (bindable, oldValue, newValue) =>
         {
@@ -47,7 +47,7 @@ namespace Tizen.NUI.Components
 
         /// <summary>
         /// SpaceBetweenTrackAndIndicatorProperty
-        /// </summary> 
+        /// </summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
         public static readonly BindableProperty SpaceBetweenTrackAndIndicatorProperty = BindableProperty.Create(nameof(SpaceBetweenTrackAndIndicator), typeof(uint?), typeof(SliderStyle), null, propertyChanged: (bindable, oldValue, newValue) =>
         {
@@ -65,7 +65,7 @@ namespace Tizen.NUI.Components
 
         /// <summary>
         /// TrackThicknessProperty
-        /// </summary> 
+        /// </summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
         public static readonly BindableProperty TrackThicknessProperty = BindableProperty.Create(nameof(TrackThickness), typeof(uint?), typeof(SliderStyle), null, propertyChanged: (bindable, oldValue, newValue) =>
         {
@@ -83,7 +83,7 @@ namespace Tizen.NUI.Components
 
         /// <summary>
         /// TrackPaddingProperty
-        /// </summary> 
+        /// </summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
         public static readonly BindableProperty TrackPaddingProperty = BindableProperty.Create(nameof(TrackPadding), typeof(Extents), typeof(SliderStyle), null, propertyChanged: (bindable, oldValue, newValue) =>
         {
@@ -178,15 +178,13 @@ namespace Tizen.NUI.Components
         /// <summary>
         /// Get or set the value indicator text.
         /// </summary>
-        /// This will be public opened later after ACR done. Before ACR, need to be hidden as inhouse API.
-        [EditorBrowsable(EditorBrowsableState.Never)]
+        /// <since_tizen> 9 </since_tizen>
         public TextLabelStyle ValueIndicatorText { get; set; } = new TextLabelStyle();
 
         /// <summary>
         /// Get or set the value indicator image.
         /// </summary>
-        /// This will be public opened later after ACR done. Before ACR, need to be hidden as inhouse API.
-        [EditorBrowsable(EditorBrowsableState.Never)]
+        /// <since_tizen> 9 </since_tizen>
         public ImageViewStyle ValueIndicatorImage { get; set; } = new ImageViewStyle();
 
         /// <summary>
-- 
2.7.4