From 6237a21d8c6ba859e043baec349ea185fa971473 Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Fri, 30 Sep 2016 21:05:45 +0000 Subject: [PATCH] Add missing std::move in Replacements::add This diff adds std::move to avoid copying of the Replacement NewR in the method Replacements::add. Test plan: make -j8 check-all Differential revision: https://reviews.llvm.org/D25049 llvm-svn: 282949 --- clang/lib/Tooling/Core/Replacement.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/lib/Tooling/Core/Replacement.cpp b/clang/lib/Tooling/Core/Replacement.cpp index 7a5fb85..bdca474 100644 --- a/clang/lib/Tooling/Core/Replacement.cpp +++ b/clang/lib/Tooling/Core/Replacement.cpp @@ -245,7 +245,7 @@ llvm::Error Replacements::add(const Replacement &R) { R.getFilePath(), R.getOffset(), 0, (R.getReplacementText() + I->getReplacementText()).str()); Replaces.erase(I); - Replaces.insert(NewR); + Replaces.insert(std::move(NewR)); return llvm::Error::success(); } // Insertion `R` is adjacent to a non-insertion replacement `I`, so they -- 2.7.4