From 621aaed95d59d3d86d84e8c4b4272ff8511b016b Mon Sep 17 00:00:00 2001 From: deepti Date: Tue, 5 Mar 2019 15:00:38 +0530 Subject: [PATCH] coverity error handling This patch initializes variables to prevent from having garbage values. Coverity: 108757, 105091 Reference : https://review.tizen.org/gerrit/#/c/platform/framework/web/crosswalk-tizen/+/174876/ Change-Id: Ic50d6d5ca42da40019c43e281eec3f5b962ff640 Signed-off-by: deepti --- common/url.cc | 5 ++++- runtime/browser/web_view_impl.cc | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/common/url.cc b/common/url.cc index 898190cc2..4a91a9512 100644 --- a/common/url.cc +++ b/common/url.cc @@ -54,7 +54,7 @@ int GetDefaultPort(const std::string& scheme) { class URLImpl { public: explicit URLImpl(const std::string& url); - URLImpl() {} + URLImpl(); std::string url() const { return url_; } std::string scheme() const { return scheme_; } @@ -75,6 +75,9 @@ class URLImpl { void ExtractPath(); }; +URLImpl::URLImpl() : port_(0) { +} + URLImpl::URLImpl(const std::string& url) : port_(0) { if (url.empty()) return; diff --git a/runtime/browser/web_view_impl.cc b/runtime/browser/web_view_impl.cc index 01050c5dc..83a535682 100755 --- a/runtime/browser/web_view_impl.cc +++ b/runtime/browser/web_view_impl.cc @@ -923,6 +923,8 @@ void WebViewImpl::InitEditorClientImeCallback() { SoftKeyboardChangeEventValue softkeyboard_value; softkeyboard_value.state = "off"; + softkeyboard_value.width = 0; + softkeyboard_value.height = 0; self->listener_->OnSoftKeyboardChangeEvent(self->view_, softkeyboard_value); }; -- 2.34.1