From 61c5492ade04e0e4885f062e63c9f5d91f769541 Mon Sep 17 00:00:00 2001 From: Nicholas Clark Date: Wed, 17 Nov 2010 10:58:46 +0000 Subject: [PATCH] In S_pad_check_dup(), no need to check the 0th name entry. The 0th entry in a pad is for @_, and the name corresponding to it is NULL, so save a check. --- pad.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pad.c b/pad.c index 2c1c81d..06cadbb 100644 --- a/pad.c +++ b/pad.c @@ -662,7 +662,7 @@ S_pad_check_dup(pTHX_ SV *name, const U32 flags, const HV *ourstash) } /* check the rest of the pad */ if (is_our) { - do { + while (off > 0) { SV * const sv = svp[off]; if (sv && sv != &PL_sv_undef @@ -678,7 +678,8 @@ S_pad_check_dup(pTHX_ SV *name, const U32 flags, const HV *ourstash) "\t(Did you mean \"local\" instead of \"our\"?)\n"); break; } - } while ( off-- > 0 ); + --off; + } } } -- 2.7.4