From 61b83fba276be794a2e182d99d3e46c4ea9bc7c6 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Thu, 3 Jun 2021 17:38:35 -0400 Subject: [PATCH] panfrost: Disable AFBC on v7 Broken in several ways. Hide it until we can get this sorted, and have a test plan to keep it sorted. Signed-off-by: Alyssa Rosenzweig Cc: mesa-stable Acked-by: Boris Brezillon Part-of: --- src/gallium/drivers/panfrost/ci/deqp-panfrost-g52-fails.txt | 12 ------------ src/gallium/drivers/panfrost/pan_screen.c | 8 ++++++++ 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/panfrost/ci/deqp-panfrost-g52-fails.txt b/src/gallium/drivers/panfrost/ci/deqp-panfrost-g52-fails.txt index d12c141..294345d 100644 --- a/src/gallium/drivers/panfrost/ci/deqp-panfrost-g52-fails.txt +++ b/src/gallium/drivers/panfrost/ci/deqp-panfrost-g52-fails.txt @@ -1,15 +1,3 @@ -dEQP-GLES31.functional.draw_buffers_indexed.random.max_implementation_draw_buffers.10,Fail -dEQP-GLES31.functional.draw_buffers_indexed.random.max_implementation_draw_buffers.11,Fail -dEQP-GLES31.functional.draw_buffers_indexed.random.max_implementation_draw_buffers.13,Fail -dEQP-GLES31.functional.draw_buffers_indexed.random.max_implementation_draw_buffers.14,Fail -dEQP-GLES31.functional.draw_buffers_indexed.random.max_implementation_draw_buffers.15,Fail -dEQP-GLES31.functional.draw_buffers_indexed.random.max_implementation_draw_buffers.17,Fail -dEQP-GLES31.functional.draw_buffers_indexed.random.max_implementation_draw_buffers.18,Fail -dEQP-GLES31.functional.draw_buffers_indexed.random.max_implementation_draw_buffers.1,Fail -dEQP-GLES31.functional.draw_buffers_indexed.random.max_implementation_draw_buffers.2,Fail -dEQP-GLES31.functional.draw_buffers_indexed.random.max_implementation_draw_buffers.5,Fail -dEQP-GLES31.functional.draw_buffers_indexed.random.max_implementation_draw_buffers.9,Fail -dEQP-GLES31.functional.draw_buffers_indexed.random.max_required_draw_buffers.10,Fail dEQP-GLES31.functional.draw_indirect.draw_elements_indirect.line_strip.instanced_attributes,Fail dEQP-GLES31.functional.draw_indirect.random.31,Fail dEQP-GLES31.functional.layout_binding.image.image2d.vertex_binding_max_array,Fail diff --git a/src/gallium/drivers/panfrost/pan_screen.c b/src/gallium/drivers/panfrost/pan_screen.c index ed0e8ac..c49a7c1 100644 --- a/src/gallium/drivers/panfrost/pan_screen.c +++ b/src/gallium/drivers/panfrost/pan_screen.c @@ -826,6 +826,14 @@ panfrost_create_screen(int fd, struct renderonly *ro) if (dev->debug & PAN_DBG_NO_AFBC) dev->quirks |= MIDGARD_NO_AFBC; + /* XXX: AFBC is currently broken on Bifrost in a few different ways + * + * - Preload is broken if the effective tile size is not 16x16 + * - Some systems lack AFBC but we need kernel changes to know that + */ + if (dev->arch == 7) + dev->quirks |= MIDGARD_NO_AFBC; + dev->ro = ro; /* Check if we're loading against a supported GPU model. */ -- 2.7.4