From 619c63cbaf6971956df6264a45b9d6dac68ec58d Mon Sep 17 00:00:00 2001 From: Trevor Morris Date: Thu, 9 Jan 2020 11:06:38 -0800 Subject: [PATCH] Use int for endch to fix portability issues regarding signed/unsigned char (#4668) --- src/common/base64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/base64.h b/src/common/base64.h index a2d8af8..0d2b6a1 100644 --- a/src/common/base64.h +++ b/src/common/base64.h @@ -258,7 +258,7 @@ class Base64OutStream: public dmlc::Stream { * \brief finish writing of all current base64 stream, do some post processing * \param endch character to put to end of stream, if it is EOF, then nothing will be appended. */ - void Finish(char endch = EOF) { + void Finish(int endch = EOF) { using base64::EncodeTable; if (buf__top_ == 1) { PutChar(EncodeTable[buf_[1] >> 2]); -- 2.7.4