From 6136bfffcec66e05235d5a07691175dddbd7a6de Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Tue, 3 Jul 2012 15:24:27 +0200 Subject: [PATCH] Fix QWidget/widgetAt() test. Prevent a crash by giving the widget some time to show up. Task-number: QTBUG-22326 Change-Id: Idaa23b21121e7c4f7098e8d51efd313bcc467e9a Reviewed-by: Joerg Bornemann --- tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp b/tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp index 36567b0..ffbe39e 100644 --- a/tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp +++ b/tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp @@ -3125,11 +3125,13 @@ void tst_QWidget::widgetAt() #if defined(Q_OS_WINCE) QEXPECT_FAIL("", "Windows CE does only support rectangular regions", Continue); //See also task 147191 #endif - /// ### fixme: Check platforms - QEXPECT_FAIL("", "Window mask not implemented on Lighthouse QTBUG-22326", Continue); + if (!QGuiApplication::platformName().compare(QLatin1String("cocoa"), Qt::CaseInsensitive)) + QEXPECT_FAIL("", "Window mask not implemented on Mac QTBUG-22326", Continue); - QTRY_COMPARE(QApplication::widgetAt(100,100)->objectName(), w1->objectName()); - QTRY_COMPARE(QApplication::widgetAt(101,101)->objectName(), w2->objectName()); + QTRY_VERIFY((wr = QApplication::widgetAt(100,100))); + QTRY_COMPARE(wr->objectName(), w1->objectName()); + QTRY_VERIFY((wr = QApplication::widgetAt(101,101))); + QTRY_COMPARE(wr->objectName(), w2->objectName()); QBitmap bitmap(w2->size()); QPainter p(&bitmap); @@ -3143,8 +3145,8 @@ void tst_QWidget::widgetAt() #if defined(Q_OS_WINCE) QEXPECT_FAIL("", "Windows CE does only support rectangular regions", Continue); //See also task 147191 #endif - /// ### fixme: Check platforms - QEXPECT_FAIL("", "Window mask not implemented on Lighthouse QTBUG-22326", Continue); + if (!QGuiApplication::platformName().compare(QLatin1String("cocoa"), Qt::CaseInsensitive)) + QEXPECT_FAIL("", "Window mask not implemented on Mac QTBUG-22326", Continue); QTRY_VERIFY(QApplication::widgetAt(100,100) == w1); QTRY_VERIFY(QApplication::widgetAt(101,101) == w2); -- 2.7.4