From 610c40885522ea3470f6284557b64cb983c9dbf0 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Fri, 26 Feb 2016 10:02:04 +0000 Subject: [PATCH] [PM] Remove a FIXME now that it is no longer needed. This has been fixed for some time, but the code hadn't been updated. llvm-svn: 261996 --- llvm/include/llvm/Analysis/AssumptionCache.h | 6 +----- llvm/include/llvm/Analysis/DominanceFrontier.h | 6 +----- llvm/include/llvm/Analysis/LoopInfo.h | 6 +----- llvm/include/llvm/Analysis/PostDominators.h | 4 +--- llvm/include/llvm/Analysis/RegionInfo.h | 6 +----- llvm/include/llvm/IR/Dominators.h | 6 +----- 6 files changed, 6 insertions(+), 28 deletions(-) diff --git a/llvm/include/llvm/Analysis/AssumptionCache.h b/llvm/include/llvm/Analysis/AssumptionCache.h index b903f96..e299bd1 100644 --- a/llvm/include/llvm/Analysis/AssumptionCache.h +++ b/llvm/include/llvm/Analysis/AssumptionCache.h @@ -22,16 +22,12 @@ #include "llvm/IR/Function.h" #include "llvm/IR/Instructions.h" #include "llvm/IR/ValueHandle.h" +#include "llvm/IR/PassManager.h" #include "llvm/Pass.h" #include namespace llvm { -// FIXME: Replace this brittle forward declaration with the include of the new -// PassManager.h when doing so doesn't break the PassManagerBuilder. -template class AnalysisManager; -class PreservedAnalyses; - /// \brief A cache of @llvm.assume calls within a function. /// /// This cache provides fast lookup of assumptions within a function by caching diff --git a/llvm/include/llvm/Analysis/DominanceFrontier.h b/llvm/include/llvm/Analysis/DominanceFrontier.h index b4b8a6b..5f8805d 100644 --- a/llvm/include/llvm/Analysis/DominanceFrontier.h +++ b/llvm/include/llvm/Analysis/DominanceFrontier.h @@ -19,16 +19,12 @@ #define LLVM_ANALYSIS_DOMINANCEFRONTIER_H #include "llvm/IR/Dominators.h" +#include "llvm/IR/PassManager.h" #include #include namespace llvm { -// FIXME: Replace this brittle forward declaration with the include of the new -// PassManager.h when doing so doesn't break the PassManagerBuilder. -template class AnalysisManager; -class PreservedAnalyses; - //===----------------------------------------------------------------------===// /// DominanceFrontierBase - Common base class for computing forward and inverse /// dominance frontiers for a function. diff --git a/llvm/include/llvm/Analysis/LoopInfo.h b/llvm/include/llvm/Analysis/LoopInfo.h index d9d2b85..c37936f 100644 --- a/llvm/include/llvm/Analysis/LoopInfo.h +++ b/llvm/include/llvm/Analysis/LoopInfo.h @@ -44,16 +44,12 @@ #include "llvm/IR/CFG.h" #include "llvm/IR/Instruction.h" #include "llvm/IR/Instructions.h" +#include "llvm/IR/PassManager.h" #include "llvm/Pass.h" #include namespace llvm { -// FIXME: Replace this brittle forward declaration with the include of the new -// PassManager.h when doing so doesn't break the PassManagerBuilder. -template class AnalysisManager; -class PreservedAnalyses; - class DominatorTree; class LoopInfo; class Loop; diff --git a/llvm/include/llvm/Analysis/PostDominators.h b/llvm/include/llvm/Analysis/PostDominators.h index 93884c76..403d85a 100644 --- a/llvm/include/llvm/Analysis/PostDominators.h +++ b/llvm/include/llvm/Analysis/PostDominators.h @@ -15,11 +15,9 @@ #define LLVM_ANALYSIS_POSTDOMINATORS_H #include "llvm/IR/Dominators.h" +#include "llvm/IR/PassManager.h" namespace llvm { -// FIXME: Replace this brittle forward declaration with the include of the new -// PassManager.h when doing so doesn't break the PassManagerBuilder. -class PreservedAnalyses; /// PostDominatorTree Class - Concrete subclass of DominatorTree that is used to /// compute the post-dominator tree. diff --git a/llvm/include/llvm/Analysis/RegionInfo.h b/llvm/include/llvm/Analysis/RegionInfo.h index 394a503..72ef070 100644 --- a/llvm/include/llvm/Analysis/RegionInfo.h +++ b/llvm/include/llvm/Analysis/RegionInfo.h @@ -41,17 +41,13 @@ #include "llvm/ADT/PointerIntPair.h" #include "llvm/IR/CFG.h" #include "llvm/IR/Dominators.h" +#include "llvm/IR/PassManager.h" #include #include #include namespace llvm { -// FIXME: Replace this brittle forward declaration with the include of the new -// PassManager.h when doing so doesn't break the PassManagerBuilder. -template class AnalysisManager; -class PreservedAnalyses; - // Class to be specialized for different users of RegionInfo // (i.e. BasicBlocks or MachineBasicBlocks). This is only to avoid needing to // pass around an unreasonable number of template parameters. diff --git a/llvm/include/llvm/IR/Dominators.h b/llvm/include/llvm/IR/Dominators.h index 37447c3..7a16ce9 100644 --- a/llvm/include/llvm/IR/Dominators.h +++ b/llvm/include/llvm/IR/Dominators.h @@ -23,6 +23,7 @@ #include "llvm/IR/BasicBlock.h" #include "llvm/IR/CFG.h" #include "llvm/IR/Function.h" +#include "llvm/IR/PassManager.h" #include "llvm/Pass.h" #include "llvm/Support/Compiler.h" #include "llvm/Support/GenericDomTree.h" @@ -31,11 +32,6 @@ namespace llvm { -// FIXME: Replace this brittle forward declaration with the include of the new -// PassManager.h when doing so doesn't break the PassManagerBuilder. -template class AnalysisManager; -class PreservedAnalyses; - extern template class DomTreeNodeBase; extern template class DominatorTreeBase; -- 2.7.4