From 60c1a8c01a2c87b3dfde4374c847cf7128b683a3 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Thu, 25 Jun 2015 16:01:53 +0000 Subject: [PATCH] llvm-nm: print 'n' instead of '?' This matches gnu nm and has the advantage that there is a upper case N. llvm-svn: 240655 --- llvm/test/Object/X86/nm-print-size.s | 7 ++++++- llvm/tools/llvm-nm/llvm-nm.cpp | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/llvm/test/Object/X86/nm-print-size.s b/llvm/test/Object/X86/nm-print-size.s index 6709ed9..b833601 100644 --- a/llvm/test/Object/X86/nm-print-size.s +++ b/llvm/test/Object/X86/nm-print-size.s @@ -1,7 +1,12 @@ // RUN: llvm-mc %s -o %t -filetype=obj -triple=x86_64-pc-linux // RUN: llvm-nm --print-size %t | FileCheck %s -// CHECK: 0000000000000000 ffffffffffffffff t a +// CHECK: 0000000000000000 ffffffffffffffff n a +// CHECK: 0000000000000000 0000000000000000 N b + .section foo a: .size a, 0xffffffffffffffff + + .global b +b: diff --git a/llvm/tools/llvm-nm/llvm-nm.cpp b/llvm/tools/llvm-nm/llvm-nm.cpp index 3ef909a..feff6aa 100644 --- a/llvm/tools/llvm-nm/llvm-nm.cpp +++ b/llvm/tools/llvm-nm/llvm-nm.cpp @@ -675,7 +675,7 @@ static char getSymbolNMTypeChar(ELFObjectFile &Obj, .Default('?'); } - return '?'; + return 'n'; } static char getSymbolNMTypeChar(COFFObjectFile &Obj, symbol_iterator I) { -- 2.7.4