From 609f5e050cea760694a46e126e5aa3f62660cae9 Mon Sep 17 00:00:00 2001 From: Diego Caballero Date: Fri, 4 Sep 2020 11:44:32 -0700 Subject: [PATCH] [mlir] Rename 'setInsertionPointAfter' to avoid ambiguity Rename 'setInsertionPointAfter(Value)' API to avoid ambiguity with 'setInsertionPointAfter(Operation *)' for SingleResult operations which implicitly convert to Value (see D86756). Differential Revision: https://reviews.llvm.org/D87155 --- mlir/include/mlir/IR/Builders.h | 2 +- mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mlir/include/mlir/IR/Builders.h b/mlir/include/mlir/IR/Builders.h index 0c308697..ccf1148 100644 --- a/mlir/include/mlir/IR/Builders.h +++ b/mlir/include/mlir/IR/Builders.h @@ -333,7 +333,7 @@ public: /// defining operation. This will cause subsequent insertions to go right /// after it. Otherwise, value is a BlockArgumen. Sets the insertion point to /// the start of its block. - void setInsertionPointAfter(Value val) { + void setInsertionPointAfterValue(Value val) { if (Operation *op = val.getDefiningOp()) { setInsertionPointAfter(op); } else { diff --git a/mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp b/mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp index 1de7b89..ee52fe4 100644 --- a/mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp +++ b/mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp @@ -945,7 +945,7 @@ static bool isUniformDefinition(Value value, /// vectorization strategy in 'state'. static Value vectorizeUniform(Value value, VectorizationState *state) { OpBuilder builder(value.getContext()); - builder.setInsertionPointAfter(value); + builder.setInsertionPointAfterValue(value); auto vectorTy = getVectorType(value.getType(), state->strategy); auto bcast = builder.create(value.getLoc(), vectorTy, value); -- 2.7.4