From 60514f37de6af064cdf91f7dbb8ac63b51653cde Mon Sep 17 00:00:00 2001 From: Changgyu Choi Date: Wed, 24 Feb 2021 12:18:54 +0900 Subject: [PATCH] Fix static issues Changes: * Fix memory leak. * Remove FilterParcelable::uid_ Signed-off-by: Changgyu Choi --- src/client/pkginfo_client.cc | 1 + src/common/parcel/filter_parcelable.cc | 3 +-- src/common/parcel/filter_parcelable.hh | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/client/pkginfo_client.cc b/src/client/pkginfo_client.cc index 5b83d77..9887cc8 100644 --- a/src/client/pkginfo_client.cc +++ b/src/client/pkginfo_client.cc @@ -86,6 +86,7 @@ PkgInfoClient::GetResultParcel() { if (socket_->ReceiveData(raw, len) != 0) { LOGE("Fail to receive data"); + delete[] raw; return nullptr; } diff --git a/src/common/parcel/filter_parcelable.cc b/src/common/parcel/filter_parcelable.cc index e745f67..f314eea 100644 --- a/src/common/parcel/filter_parcelable.cc +++ b/src/common/parcel/filter_parcelable.cc @@ -26,8 +26,7 @@ namespace pkgmgr_common { namespace parcel { FilterParcelable::FilterParcelable() : - AbstractParcelable(0, ParcelableType::Filter), - uid_(0), filter_(nullptr), flag_(0) {} + AbstractParcelable(0, ParcelableType::Filter), filter_(nullptr), flag_(0) {} FilterParcelable::FilterParcelable(uid_t uid, pkgmgrinfo_filter_x *filter, int flag) : AbstractParcelable(uid, ParcelableType::Filter), diff --git a/src/common/parcel/filter_parcelable.hh b/src/common/parcel/filter_parcelable.hh index 8c25b47..4d0e7b2 100644 --- a/src/common/parcel/filter_parcelable.hh +++ b/src/common/parcel/filter_parcelable.hh @@ -38,7 +38,6 @@ class EXPORT_API FilterParcelable : public AbstractParcelable { pkgmgrinfo_node_x *ReadPkgmgrInfoNode(tizen_base::Parcel *parcel); pkgmgrinfo_metadata_node_x *ReadPkgmgrInfoMetadataNode(tizen_base::Parcel* parcel); - uid_t uid_; pkgmgrinfo_filter_x *filter_; int flag_; }; -- 2.7.4