From 6034230db7ef61b97908d72d8a115390c2debfc7 Mon Sep 17 00:00:00 2001 From: "mstarzinger@chromium.org" Date: Tue, 9 Sep 2014 14:48:16 +0000 Subject: [PATCH] Some follow-up fixes after r23801. R=rossberg@chromium.org TEST=mjsunit --turbo-types Review URL: https://codereview.chromium.org/559563002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/compiler/js-operator.h | 2 +- src/compiler/typer.cc | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/compiler/js-operator.h b/src/compiler/js-operator.h index f2d039e..cb3c47c 100644 --- a/src/compiler/js-operator.h +++ b/src/compiler/js-operator.h @@ -156,7 +156,7 @@ class JSOperatorBuilder { } Operator* StoreContext(uint16_t depth, uint32_t index) { ContextAccess access(depth, index, false); - OP1(JSStoreContext, ContextAccess, access, Operator::kNoProperties, 2, 1); + OP1(JSStoreContext, ContextAccess, access, Operator::kNoProperties, 2, 0); } Operator* TypeOf() { SIMPLE(JSTypeOf, Operator::kPure, 1, 1); } diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc index 3b56265..da66a82 100644 --- a/src/compiler/typer.cc +++ b/src/compiler/typer.cc @@ -303,14 +303,13 @@ Bounds Typer::Visitor::TypeFinish(Node* node) { Bounds Typer::Visitor::TypeFrameState(Node* node) { - UNREACHABLE(); - return Bounds(); + // TODO(rossberg): Ideally FrameState wouldn't have a value output. + return Bounds(Type::Internal(zone())); } Bounds Typer::Visitor::TypeStateValues(Node* node) { - UNREACHABLE(); - return Bounds(); + return Bounds(Type::Internal(zone())); } -- 2.7.4