From 602b9608f53dddaedd1c43239cc476d26e2a589e Mon Sep 17 00:00:00 2001 From: "commit-bot@chromium.org" Date: Tue, 29 Oct 2013 15:32:09 +0000 Subject: [PATCH] Get rid of two unused variables from the .data section. Before: $ objdump -x out/Release/libskia_opts.a | grep "\.data" | c++filt 1 .data 00000000 0000000000000000 0000000000000000 000004ec 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00000f58 2**2 0000000000000000 l d .data 0000000000000000 .data 2 .data 00000008 0000000000000000 0000000000000000 00001774 2**2 0000000000000000 l d .data 0000000000000000 .data 0000000000000000 g O .data 0000000000000004 debug_x 0000000000000004 g O .data 0000000000000004 debug_y 1 .data 00000000 0000000000000000 0000000000000000 00001d8c 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00000054 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 000001f0 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00000044 2**2 0000000000000000 l d .data 0000000000000000 .data After: $ objdump -x out/Release/libskia_opts.a | grep "\.data" | c++filt 1 .data 00000000 0000000000000000 0000000000000000 000004ec 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00000f58 2**2 0000000000000000 l d .data 0000000000000000 .data 2 .data 00000000 0000000000000000 0000000000000000 00001774 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00001d8c 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00000054 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 000001f0 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00000044 2**2 0000000000000000 l d .data 0000000000000000 .data Not sure why clang didn't catch them. R=mtklein@google.com BUG= Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/50013002 git-svn-id: http://skia.googlecode.com/svn/trunk@11999 2bbb7eff-a529-9590-31e7-b0007b416f81 --- src/opts/SkBitmapFilter_opts_SSE2.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/opts/SkBitmapFilter_opts_SSE2.cpp b/src/opts/SkBitmapFilter_opts_SSE2.cpp index 95492c5..259e2ef 100644 --- a/src/opts/SkBitmapFilter_opts_SSE2.cpp +++ b/src/opts/SkBitmapFilter_opts_SSE2.cpp @@ -45,11 +45,8 @@ static inline void print128f(__m128 value) { // because the border is handled specially, this is guaranteed to have all 16 pixels // available to it without running off the bitmap's edge. -int debug_x = 20; -int debug_y = 255; - void highQualityFilter_SSE2(const SkBitmapProcState& s, int x, int y, - SkPMColor* SK_RESTRICT colors, int count) { + SkPMColor* SK_RESTRICT colors, int count) { const int maxX = s.fBitmap->width() - 1; const int maxY = s.fBitmap->height() - 1; -- 2.7.4