From 6029f9d9b0a1c7d6c0820cff8f522c15a62a378f Mon Sep 17 00:00:00 2001 From: Jia Jie Ho Date: Mon, 4 Dec 2023 11:02:39 +0800 Subject: [PATCH] crypto: starfive - Remove unneeded NULL checks NULL check before kfree_sensitive function is not needed. Signed-off-by: Jia Jie Ho Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311301702.LxswfETY-lkp@intel.com/ Signed-off-by: Herbert Xu (cherry picked from mainline commit 555e387047761eb909a0a1a8230efad3fa3e82ca) Signed-off-by: Jaehoon Chung Change-Id: I2b868f089ac0bf9fa49bf2657f3fea98fa5c2cfa --- drivers/crypto/starfive/jh7110-rsa.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/starfive/jh7110-rsa.c b/drivers/crypto/starfive/jh7110-rsa.c index c2b1f598873c..cf8bda7f0855 100644 --- a/drivers/crypto/starfive/jh7110-rsa.c +++ b/drivers/crypto/starfive/jh7110-rsa.c @@ -45,12 +45,9 @@ static inline int starfive_pka_wait_done(struct starfive_cryp_ctx *ctx) static void starfive_rsa_free_key(struct starfive_rsa_key *key) { - if (key->d) - kfree_sensitive(key->d); - if (key->e) - kfree_sensitive(key->e); - if (key->n) - kfree_sensitive(key->n); + kfree_sensitive(key->d); + kfree_sensitive(key->e); + kfree_sensitive(key->n); memset(key, 0, sizeof(*key)); } -- 2.34.1