From 5fe8bd99198e48ecbae59ae58e29ae3a4bcec5d2 Mon Sep 17 00:00:00 2001 From: "sgjesse@chromium.org" Date: Wed, 27 Jan 2010 16:18:58 +0000 Subject: [PATCH] Fix 64-bit build on Windows and Visual Studio project files 64-bit version now builds on Windows again in both release and debug mode. The Visual Studio project files have been updated so that all three configurations work (32-bit, 64-bit and 32-bit with ARM simulator). They all convert from Visual Studio 2005 to Visual Studio 2008. TBR=lrn@chromium.org Review URL: http://codereview.chromium.org/549174 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3722 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- SConstruct | 8 +- src/spaces.h | 2 +- test/cctest/test-serialize.cc | 6 +- tools/visual_studio/common.vsprops | 1 - tools/visual_studio/d8.vcproj | 6 - tools/visual_studio/d8_arm.vcproj | 392 ++++++++------- tools/visual_studio/d8_x64.vcproj | 24 +- tools/visual_studio/ia32.vsprops | 4 + tools/visual_studio/v8_arm.vcproj | 446 +++++++++--------- tools/visual_studio/v8_base_x64.vcproj | 13 + tools/visual_studio/v8_cctest.vcproj | 6 - tools/visual_studio/v8_cctest_arm.vcproj | 6 - tools/visual_studio/v8_cctest_x64.vcproj | 12 - tools/visual_studio/v8_mksnapshot.vcproj | 6 - tools/visual_studio/v8_mksnapshot_x64.vcproj | 6 - tools/visual_studio/v8_process_sample.vcproj | 6 - .../v8_process_sample_arm.vcproj | 296 ++++++------ .../v8_process_sample_x64.vcproj | 22 +- tools/visual_studio/v8_shell_sample.vcproj | 6 - .../visual_studio/v8_shell_sample_arm.vcproj | 296 ++++++------ .../visual_studio/v8_shell_sample_x64.vcproj | 24 +- tools/visual_studio/x64.vsprops | 4 + 22 files changed, 780 insertions(+), 812 deletions(-) diff --git a/SConstruct b/SConstruct index 2967d92e0..c9c5a55c8 100644 --- a/SConstruct +++ b/SConstruct @@ -281,18 +281,12 @@ V8_EXTRA_FLAGS = { }, 'msvc': { 'all': { - 'WARNINGFLAGS': ['/WX', '/wd4355', '/wd4800'] + 'WARNINGFLAGS': ['/W3', '/WX', '/wd4355', '/wd4800'] }, 'library:shared': { 'CPPDEFINES': ['BUILDING_V8_SHARED'], 'LIBS': ['winmm', 'ws2_32'] }, - 'arch:ia32': { - 'WARNINGFLAGS': ['/W3'] - }, - 'arch:x64': { - 'WARNINGFLAGS': ['/W3'] - }, 'arch:arm': { 'CPPDEFINES': ['V8_TARGET_ARCH_ARM'], # /wd4996 is to silence the warning about sscanf diff --git a/src/spaces.h b/src/spaces.h index f7a04398e..37117f95c 100644 --- a/src/spaces.h +++ b/src/spaces.h @@ -1837,7 +1837,7 @@ class MapSpace : public FixedSpace { #ifdef DEBUG if (FLAG_enable_slow_asserts) { - int actual_size = 0; + intptr_t actual_size = 0; for (Page* p = first_page_; p != top_page; p = p->next_page()) actual_size += kMapsPerPage * Map::kSize; actual_size += (new_top - top_page->ObjectAreaStart()); diff --git a/test/cctest/test-serialize.cc b/test/cctest/test-serialize.cc index 81b6b713c..c34840ace 100644 --- a/test/cctest/test-serialize.cc +++ b/test/cctest/test-serialize.cc @@ -217,7 +217,7 @@ void FileByteSink::WriteSpaceUsed( int map_space_used, int cell_space_used, int large_space_used) { - int file_name_length = strlen(file_name_) + 10; + int file_name_length = StrLength(file_name_) + 10; Vector name = Vector::New(file_name_length + 1); OS::SNPrintF(name, "%s.size", file_name_); FILE* fp = OS::FOpen(name.start(), "w"); @@ -368,7 +368,7 @@ TEST(PartialSerialization) { raw_foo = *(v8::Utils::OpenHandle(*foo)); } - int file_name_length = strlen(FLAG_testing_serialization_file) + 10; + int file_name_length = StrLength(FLAG_testing_serialization_file) + 10; Vector startup_name = Vector::New(file_name_length + 1); OS::SNPrintF(startup_name, "%s.startup", FLAG_testing_serialization_file); @@ -394,7 +394,7 @@ TEST(PartialSerialization) { DEPENDENT_TEST(PartialDeserialization, PartialSerialization) { - int file_name_length = strlen(FLAG_testing_serialization_file) + 10; + int file_name_length = StrLength(FLAG_testing_serialization_file) + 10; Vector startup_name = Vector::New(file_name_length + 1); OS::SNPrintF(startup_name, "%s.startup", FLAG_testing_serialization_file); diff --git a/tools/visual_studio/common.vsprops b/tools/visual_studio/common.vsprops index 213a0816a..e4f75a509 100644 --- a/tools/visual_studio/common.vsprops +++ b/tools/visual_studio/common.vsprops @@ -28,7 +28,6 @@ GenerateDebugInformation="true" MapFileName="$(OutDir)\$(TargetName).map" ImportLibrary="$(OutDir)\lib\$(TargetName).lib" - TargetMachine="1" FixedBaseAddress="1" AdditionalOptions="/IGNORE:4221 /NXCOMPAT" /> diff --git a/tools/visual_studio/d8.vcproj b/tools/visual_studio/d8.vcproj index 21636ba35..8372c6760 100644 --- a/tools/visual_studio/d8.vcproj +++ b/tools/visual_studio/d8.vcproj @@ -69,9 +69,6 @@ - @@ -130,9 +127,6 @@ - diff --git a/tools/visual_studio/d8_arm.vcproj b/tools/visual_studio/d8_arm.vcproj index fbebdb35c..66adcec3d 100644 --- a/tools/visual_studio/d8_arm.vcproj +++ b/tools/visual_studio/d8_arm.vcproj @@ -1,199 +1,193 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/tools/visual_studio/d8_x64.vcproj b/tools/visual_studio/d8_x64.vcproj index 5c47a8ac8..b534a923e 100644 --- a/tools/visual_studio/d8_x64.vcproj +++ b/tools/visual_studio/d8_x64.vcproj @@ -50,7 +50,6 @@ - @@ -112,7 +108,6 @@ - @@ -146,6 +138,22 @@ + + + + + + + diff --git a/tools/visual_studio/v8_arm.vcproj b/tools/visual_studio/v8_arm.vcproj index f8cbcc4c2..d21affe9d 100644 --- a/tools/visual_studio/v8_arm.vcproj +++ b/tools/visual_studio/v8_arm.vcproj @@ -1,223 +1,223 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/tools/visual_studio/v8_base_x64.vcproj b/tools/visual_studio/v8_base_x64.vcproj index a8c8b55fa..2c22280a1 100644 --- a/tools/visual_studio/v8_base_x64.vcproj +++ b/tools/visual_studio/v8_base_x64.vcproj @@ -425,6 +425,19 @@ > + + + + + + diff --git a/tools/visual_studio/v8_cctest.vcproj b/tools/visual_studio/v8_cctest.vcproj index d1cf2e84c..9acb835c0 100644 --- a/tools/visual_studio/v8_cctest.vcproj +++ b/tools/visual_studio/v8_cctest.vcproj @@ -69,9 +69,6 @@ - @@ -130,9 +127,6 @@ - diff --git a/tools/visual_studio/v8_cctest_arm.vcproj b/tools/visual_studio/v8_cctest_arm.vcproj index 968d13472..7ff953e24 100644 --- a/tools/visual_studio/v8_cctest_arm.vcproj +++ b/tools/visual_studio/v8_cctest_arm.vcproj @@ -69,9 +69,6 @@ - @@ -130,9 +127,6 @@ - diff --git a/tools/visual_studio/v8_cctest_x64.vcproj b/tools/visual_studio/v8_cctest_x64.vcproj index 78db1a4aa..1e9044b1b 100644 --- a/tools/visual_studio/v8_cctest_x64.vcproj +++ b/tools/visual_studio/v8_cctest_x64.vcproj @@ -50,7 +50,6 @@ - @@ -112,7 +108,6 @@ - @@ -179,10 +171,6 @@ RelativePath="..\..\test\cctest\test-decls.cc" > - - diff --git a/tools/visual_studio/v8_mksnapshot.vcproj b/tools/visual_studio/v8_mksnapshot.vcproj index 00950b069..cb9e0483b 100644 --- a/tools/visual_studio/v8_mksnapshot.vcproj +++ b/tools/visual_studio/v8_mksnapshot.vcproj @@ -69,9 +69,6 @@ - @@ -130,9 +127,6 @@ - diff --git a/tools/visual_studio/v8_mksnapshot_x64.vcproj b/tools/visual_studio/v8_mksnapshot_x64.vcproj index 1c460e4db..e684af03b 100644 --- a/tools/visual_studio/v8_mksnapshot_x64.vcproj +++ b/tools/visual_studio/v8_mksnapshot_x64.vcproj @@ -69,9 +69,6 @@ - @@ -130,9 +127,6 @@ - diff --git a/tools/visual_studio/v8_process_sample.vcproj b/tools/visual_studio/v8_process_sample.vcproj index d94966b33..dc3fb3a01 100644 --- a/tools/visual_studio/v8_process_sample.vcproj +++ b/tools/visual_studio/v8_process_sample.vcproj @@ -69,9 +69,6 @@ - @@ -130,9 +127,6 @@ - diff --git a/tools/visual_studio/v8_process_sample_arm.vcproj b/tools/visual_studio/v8_process_sample_arm.vcproj index 7320231cf..2d63f69e9 100644 --- a/tools/visual_studio/v8_process_sample_arm.vcproj +++ b/tools/visual_studio/v8_process_sample_arm.vcproj @@ -1,151 +1,145 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/tools/visual_studio/v8_process_sample_x64.vcproj b/tools/visual_studio/v8_process_sample_x64.vcproj index 81adbe0fb..1d7f01aeb 100644 --- a/tools/visual_studio/v8_process_sample_x64.vcproj +++ b/tools/visual_studio/v8_process_sample_x64.vcproj @@ -69,9 +69,6 @@ - @@ -130,9 +127,6 @@ - @@ -144,6 +138,22 @@ + + + + + + diff --git a/tools/visual_studio/v8_shell_sample.vcproj b/tools/visual_studio/v8_shell_sample.vcproj index 2cbd22df6..b1e5f0178 100644 --- a/tools/visual_studio/v8_shell_sample.vcproj +++ b/tools/visual_studio/v8_shell_sample.vcproj @@ -69,9 +69,6 @@ - @@ -130,9 +127,6 @@ - diff --git a/tools/visual_studio/v8_shell_sample_arm.vcproj b/tools/visual_studio/v8_shell_sample_arm.vcproj index ba7e0e055..a14c91a45 100644 --- a/tools/visual_studio/v8_shell_sample_arm.vcproj +++ b/tools/visual_studio/v8_shell_sample_arm.vcproj @@ -1,151 +1,145 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/tools/visual_studio/v8_shell_sample_x64.vcproj b/tools/visual_studio/v8_shell_sample_x64.vcproj index e1d516486..44d7b12c7 100644 --- a/tools/visual_studio/v8_shell_sample_x64.vcproj +++ b/tools/visual_studio/v8_shell_sample_x64.vcproj @@ -50,7 +50,6 @@ - @@ -112,7 +108,6 @@ - @@ -146,6 +138,22 @@ + + + + + + diff --git a/tools/visual_studio/x64.vsprops b/tools/visual_studio/x64.vsprops index 7587acfe9..3371d54c9 100644 --- a/tools/visual_studio/x64.vsprops +++ b/tools/visual_studio/x64.vsprops @@ -10,4 +10,8 @@ Name="VCCLCompilerTool" PreprocessorDefinitions="V8_TARGET_ARCH_X64;V8_NATIVE_REGEXP" /> + -- 2.34.1