From 5fbd76750754c0ee910291f247526bf5ed938ba5 Mon Sep 17 00:00:00 2001 From: Austin Shafer Date: Mon, 15 Jun 2020 15:58:03 -0700 Subject: [PATCH] Prevent leaking extra fences These tests create fences, which are then overwritten and leaked by calls to extension functions. i.e. registering a device event creates a new fence, so the test should not create a fence and pass it to registerDeviceEventEXT. Affects: - dEQP-VK.wsi.display_control.register_display_event - dEQP-VK.wsi.display_control.register_device_event VK-GL-CTS issue: 2427 Components: Vulkan Change-Id: I2e20c13ff600429e495e98f8ff84722f298822ad --- external/vulkancts/modules/vulkan/wsi/vktWsiDisplayControlTests.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/external/vulkancts/modules/vulkan/wsi/vktWsiDisplayControlTests.cpp b/external/vulkancts/modules/vulkan/wsi/vktWsiDisplayControlTests.cpp index 77ee36b..778a1a8 100644 --- a/external/vulkancts/modules/vulkan/wsi/vktWsiDisplayControlTests.cpp +++ b/external/vulkancts/modules/vulkan/wsi/vktWsiDisplayControlTests.cpp @@ -1046,9 +1046,6 @@ tcu::TestStatus testDisplayEvent(Context& context) const DeviceInterface& vkd = context.getDeviceInterface(); std::vector fences = std::vector(availableDisplays.size(), (VkFence)0); - // create fence for each display - initFences(vkd, device, fences); - // iterate over all displays for (size_t i = 0 ; i < availableDisplays.size() ; ++i) { @@ -1081,9 +1078,6 @@ tcu::TestStatus testDeviceEvent(Context& context) const DeviceInterface& vkd = context.getDeviceInterface(); std::vector fences = std::vector(1, (VkFence)0); - // create fence - initFences(vkd, device, fences); - vk::VkDeviceEventInfoEXT deviceEventInfo = { VK_STRUCTURE_TYPE_DEVICE_EVENT_INFO_EXT, -- 2.7.4